Wrong copy & paste

rugk · Dec 25, 2015 · 4f37ac5 · 4f37ac5
1 parent 2415fac
commit 4f37ac5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/source/Threema/MsgApi/Tools/CryptTool.php b/source/Threema/MsgApi/Tools/CryptTool.php
@@ -107,14 +107,14 @@ final public function encryptMessageText($text, $senderPrivateKey, $recipientPub
 		$textBytes = "\x01" . $text;
 
 		/* determine random amount of PKCS7 padding */
-		$padbytes = mt_rand(1, 255);
-
-		/* append padding */
 		$padbytes = 0;
 		while($padbytes < 1 || $padbytes > 255) {
 			$padbytes = ord($this->createRandom(1));
 		}
 
+		/* append padding */
+		$textBytes .= str_repeat(chr($padbytes), $padbytes);
+
 		return $this->makeBox($textBytes, $nonce, $senderPrivateKey, $recipientPublicKey);
 	}