fix: do not mutate BoolQuery instance in toArray method (#2241)

fix: do not mutate BoolQuery instance for serializing when `$this->_params` is empty - #1450 --------- Co-authored-by: Marek Hauschwitz <[email protected]>
ruflin · Feb 14, 2025 · b37b636 · b37b636
1 parent 6d122c6
commit b37b636
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Deprecated
 ### Removed
 ### Fixed
+* `Elastica\Query\BoolQuery::toArray` no longer changes `$this->_params` to \stdClass when empty [#2241](https://github.com/ruflin/Elastica/pull/2241)
 ### Security
 
 ## [8.1.0](https://github.com/ruflin/Elastica/compare/8.0.0...8.1.0)

diff --git a/src/Query/BoolQuery.php b/src/Query/BoolQuery.php
@@ -87,11 +87,15 @@ public function setMinimumShouldMatch($minimum): self
 
     public function toArray(): array
     {
-        if (!$this->_params) {
-            $this->_params = new \stdClass();
+        $data = parent::toArray();
+
+        // When the query has no params, ensure that the query
+        // serializes into a JSON object instead of an empty array.
+        if (!$data[$this->_getBaseName()]) {
+            $data[$this->_getBaseName()] = new \stdClass();
         }
 
-        return parent::toArray();
+        return $data;
     }
 
     /**