Switch to Module#prepend to patch stdlib Logger #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of older style alias_method chain juggling. We hope this has fewer poor interactions with other things patching Logger as in rudionrails#60. And it's just a more modern cleaner style. Could be a first step to making this stdlib Logger patching optional, but does not require that.
jrochkind
added a commit
to sciencehistory/kithe
that referenced
this pull request
Apr 20, 2020
to avoid some kind of infinite loop, possibly involving Rails 6 zeitwerk auto-loader. Something is really wrong, this ought not to be necessary, somewhat regretting traject using yell. But for now, this simple thing seems to resolve problem. rudionrails/yell#60 rudionrails/yell#61
rudionrails
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of older style alias_method chain juggling. We hope this has fewer poor interactions with other things patching Logger as in #60. And it's just a more modern cleaner style.
Could be a first step to making this stdlib Logger patching optional, but does not require that.