chore: fix bq test

rudderlabs · Dec 24, 2024 · cd29d05 · cd29d05
1 parent 38c9251
commit cd29d05
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/warehouse/integrations/bigquery/bigquery_test.go b/warehouse/integrations/bigquery/bigquery_test.go
@@ -607,6 +607,7 @@ func TestIntegration(t *testing.T) {
 				t.Setenv("RSERVER_WAREHOUSE_BIGQUERY_ENABLE_DELETE_BY_JOBS", "true")
 				t.Setenv("RSERVER_WAREHOUSE_BIGQUERY_MAX_PARALLEL_LOADS", "8")
 				t.Setenv("RSERVER_WAREHOUSE_BIGQUERY_SLOW_QUERY_THRESHOLD", "0s")
+				t.Setenv("RSERVER_WAREHOUSE_SYNC_SCHEMA_FREQUENCY", "1s")
 
 				whth.BootstrapSvc(t, workspaceConfig, httpPort, jobsDBPort)
 

diff --git a/warehouse/router/sync.go b/warehouse/router/sync.go
@@ -5,6 +5,8 @@ import (
 	"fmt"
 	"time"
 
+	warehouseutils "github.com/rudderlabs/rudder-server/warehouse/utils"
+
 	obskit "github.com/rudderlabs/rudder-observability-kit/go/labels"
 	"github.com/rudderlabs/rudder-server/warehouse/integrations/manager"
 	"github.com/rudderlabs/rudder-server/warehouse/internal/model"
@@ -22,9 +24,10 @@ func (r *Router) syncRemoteSchema(ctx context.Context) error {
 			return fmt.Errorf("failed to create warehouse manager: %w", err)
 		}
 		for _, warehouse := range warehouses {
-			err := whManager.Setup(ctx, warehouse, nil)
+			err := whManager.Setup(ctx, warehouse, warehouseutils.NewNoOpUploader())
 			if err != nil {
-				return err
+				r.logger.Errorn("failed to setup WH Manager", obskit.Error(err))
+				continue
 			}
 			sh := schema.New(
 				r.db,

diff --git a/warehouse/schema/schema_test.go b/warehouse/schema/schema_test.go
@@ -26,6 +26,7 @@ func (m *mockStagingFileRepo) GetSchemasByIDs(context.Context, []int64) ([]model
 	}
 	return m.schemas, nil
 }
+
 func TestSchema_TableSchemaDiff(t *testing.T) {
 	testCases := []struct {
 		name              string