fix: suppress deprecation error log temporarily #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe pull request modifies the logging mechanism for deprecated SDK messages in the Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/analytics-v1.1/src/core/analytics.js (1)
1661-1673: Temporary fix approved but needs tracking.The temporary suppression of deprecation warnings using
if (false)is a valid short-term solution that aligns with the PR objective. However, to ensure this doesn't become permanent:
- Consider making the TODO comment more specific with version information
- Create a tracking issue for removing this in the next release
-// TODO: Need to remove this in the next release +// TODO(SDK-XXXX): Remove this deprecation warning suppression in version X.Y.ZWould you like me to help create a tracking issue for removing this temporary fix in the next release?
🧰 Tools
🪛 Biome (1.9.4)
[error] 1663-1663: Unexpected constant condition.
(lint/correctness/noConstantCondition)
[error] 1665-1665: Unexpected constant condition.
(lint/correctness/noConstantCondition)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/analytics-v1.1/src/core/analytics.js(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
packages/analytics-v1.1/src/core/analytics.js
[error] 1663-1663: Unexpected constant condition.
(lint/correctness/noConstantCondition)
[error] 1665-1665: Unexpected constant condition.
(lint/correctness/noConstantCondition)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Security and code quality checks
- GitHub Check: Unit Tests and Lint
- GitHub Check: Bundle size checks
- GitHub Check: Analyze (javascript-typescript)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2028 +/- ##
===========================================
- Coverage 61.36% 61.36% -0.01%
===========================================
Files 478 478
Lines 16393 16394 +1
Branches 3237 3247 +10
===========================================
Hits 10060 10060
- Misses 5100 5109 +9
+ Partials 1233 1225 -8 ☔ View full report in Codecov by Sentry. |
|
vgupta98
approved these changes
Jan 31, 2025
saikumarrs
deleted the
chore.add-legacy-sdk-deprecation-notices-new-2-sdk-2941
branch
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Temporarily suppressing the deprecation error message until the next release.
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-2941/add-deprecation-error-notices-in-legacy-sdk
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit