chore: fix globalThis polyfill in loading snippet #1821
Conversation
WalkthroughWalkthroughThe recent changes focus on enhancing the definition of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SDK
participant GlobalContext
User->>SDK: Load SDK
SDK->>GlobalContext: Check for `globalThis`
alt `globalThis` is undefined
GlobalContext->>GlobalContext: Define `getGlobal`
GlobalContext->>GlobalContext: Check for `self` or `window`
GlobalContext-->>SDK: Return valid global object
SDK->>GlobalContext: Assign `globalThis`
else `globalThis` exists
SDK-->>User: Continue as normal
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1821 +/- ##
========================================
Coverage 56.70% 56.70%
========================================
Files 473 473
Lines 16121 16121
Branches 3229 3226 -3
========================================
Hits 9141 9141
- Misses 5713 5736 +23
+ Partials 1267 1244 -23 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (15)
- README.md (1 hunks)
- packages/analytics-js/public/index.html (1 hunks)
- packages/loading-scripts/src/index.ts (1 hunks)
- packages/sanity-suite/public/v3/index-cdn.html (1 hunks)
- packages/sanity-suite/public/v3/index-local.html (1 hunks)
- packages/sanity-suite/public/v3/index-npm-bundled.html (1 hunks)
- packages/sanity-suite/public/v3/index-npm.html (1 hunks)
- packages/sanity-suite/public/v3/integrations/index-cdn.html (1 hunks)
- packages/sanity-suite/public/v3/integrations/index-local.html (1 hunks)
- packages/sanity-suite/public/v3/integrations/index-npm-bundled.html (1 hunks)
- packages/sanity-suite/public/v3/integrations/index-npm.html (1 hunks)
- packages/sanity-suite/public/v3/manualLoadCall/index-cdn.html (1 hunks)
- packages/sanity-suite/public/v3/manualLoadCall/index-local.html (1 hunks)
- packages/sanity-suite/public/v3/manualLoadCall/index-npm-bundled.html (1 hunks)
- packages/sanity-suite/public/v3/manualLoadCall/index-npm.html (1 hunks)
Files skipped from review due to trivial changes (1)
- README.md
Additional context used
Learnings (2)
packages/sanity-suite/public/v3/index-cdn.html (1)
Learnt from: saikumarrs PR: rudderlabs/rudder-sdk-js#1754 File: packages/analytics-js-common/src/utilities/page.ts:1-34 Timestamp: 2024-06-14T06:40:08.622Z Learning: The compatibility issue with `globalThis` in `packages/analytics-js-common/src/utilities/page.ts` is handled elsewhere in the codebase as per user `saikumarrs`.packages/analytics-js/public/index.html (1)
Learnt from: saikumarrs PR: rudderlabs/rudder-sdk-js#1754 File: packages/analytics-js-common/src/utilities/page.ts:1-34 Timestamp: 2024-06-14T06:40:08.622Z Learning: The compatibility issue with `globalThis` in `packages/analytics-js-common/src/utilities/page.ts` is handled elsewhere in the codebase as per user `saikumarrs`.
Additional comments not posted (14)
packages/loading-scripts/src/index.ts (1)
102-123: LGTM! Robust implementation ofglobalThispolyfill.The use of an IIFE and the
getGlobalfunction ensures that the global object is correctly determined without modifyingObject.prototype. This approach is safer and more maintainable.packages/sanity-suite/public/v3/index-npm-bundled.html (1)
98-119: LGTM! Robust implementation ofglobalThispolyfill.The use of an IIFE and the
getGlobalfunction ensures that the global object is correctly determined without modifyingObject.prototype. This approach is safer and more maintainable.packages/sanity-suite/public/v3/index-npm.html (1)
98-119: LGTM! Robust implementation ofglobalThispolyfill.The use of an IIFE and the
getGlobalfunction ensures that the global object is correctly determined without modifyingObject.prototype. This approach is safer and more maintainable.packages/sanity-suite/public/v3/integrations/index-npm-bundled.html (1)
84-105: LGTM! ImprovedglobalThispolyfill implementation.The new implementation enhances safety and clarity by avoiding prototype pollution and ensuring that
globalThisis only defined if a valid global object is found.packages/sanity-suite/public/v3/integrations/index-npm.html (1)
84-105: LGTM! ImprovedglobalThispolyfill implementation.The new implementation enhances safety and clarity by avoiding prototype pollution and ensuring that
globalThisis only defined if a valid global object is found.packages/sanity-suite/public/v3/manualLoadCall/index-npm-bundled.html (1)
84-105: LGTM! ImprovedglobalThispolyfill implementation.The new implementation enhances safety and clarity by avoiding prototype pollution and ensuring that
globalThisis only defined if a valid global object is found.packages/sanity-suite/public/v3/manualLoadCall/index-npm.html (1)
84-104: LGTM! Improved encapsulation and safety for polyfillingglobalThis.The new implementation avoids modifying
Object.prototypeand uses a helper function to determine the appropriate global object. This approach enhances robustness and maintainability.However, ensure that all instances of
globalThisusage are correctly handled across the codebase.Verification successful
Let's re-run the search for
globalThisusing the correct file type for JavaScript files and include HTML files as well.
LGTM! Improved encapsulation and safety for polyfilling
globalThis.The new implementation avoids modifying
Object.prototypeand uses a helper function to determine the appropriate global object. This approach enhances robustness and maintainability. The search results confirm that the new polyfill method is consistently applied across the codebase, and there are no instances of the old polyfill method.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all instances of `globalThis` usage in the codebase. # Test: Search for the usage of `globalThis`. Expect: No instances of the old polyfill method. rg --type javascript --type html -A 5 $'globalThis'Length of output: 85
Script:
#!/bin/bash # Description: Verify all instances of `globalThis` usage in the codebase. # Test: Search for the usage of `globalThis`. Expect: No instances of the old polyfill method. rg --type js --type html -A 5 $'globalThis'Length of output: 349181
packages/sanity-suite/public/v3/index-local.html (1)
84-104: LGTM! Improved encapsulation and safety for definingglobalThis.The new implementation avoids modifying
Object.prototypeand uses a helper function to determine the appropriate global object. This approach enhances robustness and maintainability.However, ensure that all instances of
globalThisusage are correctly handled across the codebase.Verification successful
Verification successful!
The new polyfill method for
globalThisis consistently used across the codebase, and no instances of the old polyfill method were found. This ensures that the usage ofglobalThisis correctly handled.
packages/sanity-suite/src/testBook/string.jspackages/sanity-suite/public/v3/manualLoadCall/index-npm-bundled.htmlpackages/sanity-suite/public/v3/manualLoadCall/index-cdn.htmlpackages/sanity-suite/public/v3/integrations/index-npm.htmlpackages/sanity-suite/public/v3/integrations/index-npm-bundled.htmlpackages/sanity-suite/public/v3/integrations/index-cdn.htmlpackages/sanity-suite/public/v3/index-npm.htmlpackages/sanity-suite/public/v3/index-local.htmlpackages/sanity-suite/public/v3/integrations/index-local.htmlpackages/sanity-suite/public/v3/index-npm-bundled.htmlpackages/sanity-suite/public/v3/manualLoadCall/index-npm.htmlpackages/sanity-suite/public/v1.1/manualLoadCall/index-npm.htmlpackages/sanity-suite/public/v1.1/integrations/index-npm.htmlpackages/sanity-suite/public/v1.1/manualLoadCall/index-cdn.htmlpackages/sanity-suite/public/v1.1/integrations/index-local.htmlpackages/sanity-suite/public/v1.1/manualLoadCall/index-local.htmlpackages/sanity-suite/public/v1.1/integrations/index-cdn.htmlpackages/sanity-suite/public/v1.1/index-local.htmlpackages/sanity-suite/public/v1.1/index-cdn.htmlpackages/analytics-js/__tests__/nativeSdkLoader.jsjest/jest.setup-dom.jspackages/analytics-js/public/index.htmlexamples/v3-beacon/index.htmlpackages/analytics-js-common/src/v1.1/utils/storage/v3DecryptionUtils.jsexamples/v3-legacy-minimum-plugins/index.htmlexamples/v3/index.htmlexamples/v3-minimum-plugins/index.htmlexamples/v3-legacy/index.htmlexamples/integrations/Ninetailed/sample-apps/app-using-v3-cdn/public/index.htmlexamples/chrome-extension/content-script-v3/foreground.jsexamples/chrome-extension/background-script/rudderAnalytics.jsexamples/chrome-extension/background-script-websockets/rudderAnalytics.jsassets/integrations/AdobeAnalytics/adobe-analytics-js.jsassets/integrations/AdobeAnalytics/adobe-analytics-js-heartbeat.jsexamples/chrome-extension/content-script-v1.1/foreground.jsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all instances of `globalThis` usage in the codebase. # Test: Search for the usage of `globalThis`. Expect: No instances of the old polyfill method. rg --type javascript --type html -A 5 $'globalThis'Length of output: 85
Script:
#!/bin/bash # Description: Verify all instances of `globalThis` usage in the codebase. # Find all JavaScript and HTML files and search for `globalThis` usage within them. fd -e js -e html | xargs rg 'globalThis'Length of output: 229788
packages/sanity-suite/public/v3/index-cdn.html (1)
84-104: LGTM! Improved encapsulation and safety for definingglobalThis.The new implementation avoids modifying
Object.prototypeand uses a helper function to determine the appropriate global object. This approach enhances robustness and maintainability.However, ensure that all instances of
globalThisusage are correctly handled across the codebase.packages/sanity-suite/public/v3/integrations/index-cdn.html (1)
84-104: LGTM! TheglobalThispolyfill is implemented safely.The new implementation avoids prototype pollution and enhances safety by using an IIFE and a helper function
getGlobal.However, ensure that all references to
globalThisin the codebase are correctly handled.Verification successful
All references to
globalThisare correctly handled in the codebase.The references are used appropriately in various contexts such as setting properties, accessing properties, and using it in functions.
- Files and Lines:
assets/integrations/AdobeAnalytics/adobe-analytics-js.jsassets/integrations/AdobeAnalytics/adobe-analytics-js-heartbeat.jspackages/sanity-suite/src/testBook/string.jsexamples/chrome-extension/content-script-v3/foreground.jsexamples/chrome-extension/background-script/rudderAnalytics.jsexamples/chrome-extension/background-script-websockets/rudderAnalytics.jsjest/jest.setup-dom.jsexamples/chrome-extension/content-script-v1.1/foreground.jspackages/analytics-js-common/src/v1.1/utils/storage/v3DecryptionUtils.jspackages/analytics-js/__tests__/nativeSdkLoader.jsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `globalThis` in the codebase. # Test: Search for the usage of `globalThis`. Expect: Correct handling of `globalThis`. rg --type javascript -A 5 $'globalThis'Length of output: 73
Script:
#!/bin/bash # Description: Verify all references to `globalThis` in the codebase. # Test: Search for the usage of `globalThis`. Expect: Correct handling of `globalThis`. rg --type js -A 5 $'globalThis'Length of output: 309334
packages/sanity-suite/public/v3/integrations/index-local.html (1)
84-104: LGTM! TheglobalThispolyfill is implemented safely.The new implementation avoids prototype pollution and enhances safety by using an IIFE and a helper function
getGlobal.However, ensure that all references to
globalThisin the codebase are correctly handled.Verification successful
All references to
globalThisare correctly handled.The search results indicate that
globalThisis used consistently across various files and contexts, and there are no apparent issues with its usage.
Files and lines where
globalThisis used:
assets/integrations/AdobeAnalytics/adobe-analytics-js.jsassets/integrations/AdobeAnalytics/adobe-analytics-js-heartbeat.jspackages/analytics-js/__tests__/nativeSdkLoader.jspackages/loading-scripts/src/index.tspackages/analytics-js/public/index.htmlpackages/analytics-js/src/app/RudderAnalytics.tspackages/analytics-js/src/components/preloadBuffer/index.tspackages/analytics-js/src/components/userSessionManager/UserSessionManager.tspackages/analytics-js/src/components/utilities/page.tspackages/analytics-js/src/components/capabilitiesManager/CapabilitiesManager.tspackages/analytics-js/src/components/utilities/globals.tspackages/analytics-js/src/components/core/Analytics.tspackages/analytics-js/src/components/core/utilities.tspackages/analytics-js/src/components/eventManager/utilities.tspackages/analytics-js/src/components/capabilitiesManager/detection/browser.tspackages/analytics-js/src/components/capabilitiesManager/detection/screen.tspackages/analytics-js/src/components/capabilitiesManager/detection/storage.tspackages/analytics-js/src/services/ErrorHandler/ErrorHandler.tspackages/analytics-js/src/services/StoreManager/top-domain/index.tspackages/analytics-js/src/services/StoreManager/storages/defaultOptions.tspackages/analytics-js/src/services/StoreManager/storages/sessionStorage.tspackages/analytics-js/src/components/eventRepository/EventRepository.tspackages/analytics-js/src/components/capabilitiesManager/detection/dom.tspackages/analytics-js/src/state/slices/context.tspackages/sanity-suite/src/testBook/string.jspackages/sanity-suite/public/v1.1/index-cdn.htmlpackages/sanity-suite/public/v1.1/manualLoadCall/index-cdn.htmlpackages/sanity-suite/public/v3/index-npm.htmlpackages/sanity-suite/public/v3/index-cdn.htmlpackages/sanity-suite/public/v3/integrations/index-local.htmlpackages/sanity-suite/public/v1.1/manualLoadCall/index-npm.htmlpackages/sanity-suite/public/v3/integrations/index-cdn.htmlpackages/sanity-suite/public/v3/index-local.htmlpackages/sanity-suite/public/v1.1/index-local.htmlpackages/analytics-js-plugins/src/utilities/retryQueue/RetryQueue.tspackages/analytics-js-plugins/src/utilities/retryQueue/Schedule.tspackages/analytics-js-plugins/src/oneTrustConsentManager/index.tspackages/analytics-js-plugins/src/googleLinker/base64Decoder.tspackages/analytics-js-plugins/src/ketchConsentManager/index.tspackages/analytics-js-plugins/src/bugsnag/utils.tspackages/analytics-js-plugins/src/errorReporting/utils.tspackages/analytics-js-plugins/src/deviceModeDestinations/utils.tspackages/analytics-js-common/src/utilities/url.tspackages/analytics-js-common/src/utilities/string.tspackages/analytics-js-common/src/utilities/page.tspackages/analytics-js-common/src/utilities/crypto.tspackages/analytics-js-cookies/src/component-cookie/index.tspackages/analytics-js-common/src/services/ExternalSrcLoader/jsFileLoader.tspackages/analytics-js-common/src/v1.1/utils/storage/v3DecryptionUtils.jspackages/analytics-js-cookies/__tests__/cookieUtilities.test.tsexamples/v3/index.htmlexamples/v3-minimum-plugins/index.htmlexamples/v3-legacy/index.htmlexamples/v3-beacon/index.htmlexamples/v3-legacy-minimum-plugins/index.htmlexamples/integrations/Ninetailed/sample-apps/app-using-v3-cdn/public/index.htmlexamples/chrome-extension/content-script-v3/foreground.jsexamples/chrome-extension/background-script-websockets/rudderAnalytics.jsexamples/chrome-extension/background-script/rudderAnalytics.jsexamples/chrome-extension/content-script-v1.1/foreground.jsCategory:
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `globalThis` in the codebase. # Test: Search for the usage of `globalThis`. Expect: Correct handling of `globalThis`. rg --type javascript -A 5 $'globalThis'Length of output: 73
Script:
#!/bin/bash # Description: Verify all references to `globalThis` in the codebase. # Test: Search for the usage of `globalThis`. Expect: Correct handling of `globalThis`. rg --type js --type ts --type html -A 5 $'globalThis'Length of output: 402702
packages/sanity-suite/public/v3/manualLoadCall/index-cdn.html (1)
84-104: LGTM! TheglobalThispolyfill is implemented safely.The new implementation avoids prototype pollution and enhances safety by using an IIFE and a helper function
getGlobal.However, ensure that all references to
globalThisin the codebase are correctly handled.packages/sanity-suite/public/v3/manualLoadCall/index-local.html (1)
84-104: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
window.rudderAnalyticsMountare correctly updated and tested.Verification successful
Verified: Function usage is consistent and correctly updated.
The function
window.rudderAnalyticsMountis consistently defined and invoked across multiple HTML files. The polyfill forglobalThisis included in all instances, and there are no discrepancies in its usage.
packages/sanity-suite/public/v3/index-cdn.htmlpackages/sanity-suite/public/v3/index-local.htmlpackages/sanity-suite/public/v3/integrations/index-local.htmlpackages/sanity-suite/public/v3/integrations/index-cdn.htmlpackages/sanity-suite/public/v3/manualLoadCall/index-cdn.htmlpackages/sanity-suite/public/v3/manualLoadCall/index-local.htmlexamples/v3/index.htmlexamples/v3-minimum-plugins/index.htmlpackages/analytics-js/public/index.htmlexamples/v3-legacy/index.htmlexamples/v3-legacy-minimum-plugins/index.htmlexamples/v3-beacon/index.htmlexamples/integrations/Ninetailed/sample-apps/app-using-v3-cdn/public/index.htmlScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `window.rudderAnalyticsMount` are correctly updated and tested. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --type html -A 5 $'window.rudderAnalyticsMount'Length of output: 14597
packages/analytics-js/public/index.html (1)
62-83: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
window.rudderAnalyticsMountare correctly updated and tested.
size-limit report 📦
|
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (14)
- packages/analytics-js/public/index.html (1 hunks)
- packages/loading-scripts/src/index.ts (1 hunks)
- packages/sanity-suite/public/v3/index-cdn.html (1 hunks)
- packages/sanity-suite/public/v3/index-local.html (1 hunks)
- packages/sanity-suite/public/v3/index-npm-bundled.html (1 hunks)
- packages/sanity-suite/public/v3/index-npm.html (1 hunks)
- packages/sanity-suite/public/v3/integrations/index-cdn.html (1 hunks)
- packages/sanity-suite/public/v3/integrations/index-local.html (1 hunks)
- packages/sanity-suite/public/v3/integrations/index-npm-bundled.html (1 hunks)
- packages/sanity-suite/public/v3/integrations/index-npm.html (1 hunks)
- packages/sanity-suite/public/v3/manualLoadCall/index-cdn.html (1 hunks)
- packages/sanity-suite/public/v3/manualLoadCall/index-local.html (1 hunks)
- packages/sanity-suite/public/v3/manualLoadCall/index-npm-bundled.html (1 hunks)
- packages/sanity-suite/public/v3/manualLoadCall/index-npm.html (1 hunks)
Files skipped from review as they are similar to previous changes (11)
- packages/analytics-js/public/index.html
- packages/loading-scripts/src/index.ts
- packages/sanity-suite/public/v3/index-cdn.html
- packages/sanity-suite/public/v3/index-local.html
- packages/sanity-suite/public/v3/index-npm-bundled.html
- packages/sanity-suite/public/v3/index-npm.html
- packages/sanity-suite/public/v3/integrations/index-cdn.html
- packages/sanity-suite/public/v3/integrations/index-local.html
- packages/sanity-suite/public/v3/integrations/index-npm.html
- packages/sanity-suite/public/v3/manualLoadCall/index-cdn.html
- packages/sanity-suite/public/v3/manualLoadCall/index-npm-bundled.html
Additional comments not posted (3)
packages/sanity-suite/public/v3/integrations/index-npm-bundled.html (1)
84-105: LGTM! But verify the function usage in the codebase.The code changes are approved. The approach safely defines
globalThiswithout modifyingObject.prototype.However, ensure that all references to
globalThisare correctly handled across the codebase.Verification successful
LGTM! But verify the function usage in the codebase.
The code changes are approved. The approach safely defines
globalThiswithout modifyingObject.prototype.
globalThisreferences are correctly handled across the codebase in various contexts, including setting properties, using global methods, and checking global objects.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `globalThis` are correctly handled. # Test: Search for references to `globalThis`. Expect: Correct usage across the codebase. rg --type javascript -A 5 $'globalThis'Length of output: 73
Script:
#!/bin/bash # Description: Verify all references to `globalThis` are correctly handled. # Test: Search for references to `globalThis` in .js and .jsx files. Expect: Correct usage across the codebase. rg 'globalThis' --glob '**/*.js' --glob '**/*.jsx' -A 5Length of output: 309359
packages/sanity-suite/public/v3/manualLoadCall/index-npm.html (1)
84-105: LGTM! But verify the function usage in the codebase.The code changes are approved. The approach safely defines
globalThiswithout modifyingObject.prototype.However, ensure that all references to
globalThisare correctly handled across the codebase.Verification successful
All references to
globalThisare correctly handled across the codebase.The search results show that
globalThisis used appropriately in various contexts, such as checking for its existence, defining it, and utilizing it in different scripts and modules.
File:
packages/sanity-suite/src/testBook/string.js
- Usage:
return globalThis.btoa(binString);- Context: This usage ensures that the
btoamethod is called from the global context, which is correct.File:
packages/sanity-suite/public/v3/index-npm.html
- Usage: Several instances where
globalThisis defined and checked.- Context: This ensures that
globalThisis polyfilled if not available, which is a correct approach.File:
packages/sanity-suite/public/v3/manualLoadCall/index-npm.html
- Usage: Similar to
index-npm.html, ensuringglobalThisis defined if not available.File:
packages/analytics-js/src/components/utilities/page.ts
- Usage: Multiple usages like
globalThis.navigatorandglobalThis.location.- Context: These usages are correct as they access global properties.
File:
examples/chrome-extension/content-script-v3/foreground.js
- Usage: Multiple instances of
globalThisfor accessing global properties and methods.- Context: Correctly used to ensure the code runs in the global context.
File:
examples/chrome-extension/background-script-websockets/rudderAnalytics.js
- Usage:
const _global=(()=>{/*eslint no-undef:0*/if(typeof globalThis!=="undefined")return globalThis;- Context: This snippet ensures compatibility across different environments by checking for
globalThis.File:
examples/chrome-extension/background-script/rudderAnalytics.js
- Usage: Similar to
rudderAnalytics.jsin the websockets directory.File:
examples/chrome-extension/content-script-v1.1/foreground.js
- Usage: Multiple instances of
globalThisfor accessing global properties and methods.- Context: Correctly used to ensure the code runs in the global context.
Category:
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `globalThis` are correctly handled. # Test: Search for references to `globalThis`. Expect: Correct usage across the codebase. rg --type javascript -A 5 $'globalThis'Length of output: 73
Script:
#!/bin/bash # Description: Verify all references to `globalThis` are correctly handled. # Test: Search for references to `globalThis`. Expect: Correct usage across the codebase. rg -A 5 $'globalThis'Length of output: 406716
packages/sanity-suite/public/v3/manualLoadCall/index-local.html (1)
84-105: LGTM! But verify the function usage in the codebase.The code changes are approved. The approach safely defines
globalThiswithout modifyingObject.prototype.However, ensure that all references to
globalThisare correctly handled across the codebase.Verification successful
Verification Successful: All references to
globalThisare correctly handled across the codebase.The search results indicate that
globalThisis used consistently and appropriately in various files and contexts throughout the codebase.
- Files and lines with
globalThisusage:
jest/jest.setup-dom.jspackages/sanity-suite/src/testBook/string.jsexamples/chrome-extension/background-script/rudderAnalytics.jsexamples/chrome-extension/background-script-websockets/rudderAnalytics.jsexamples/chrome-extension/content-script-v3/foreground.jspackages/analytics-js/src/testBook/string.jspackages/analytics-js/src/services/StoreManager/top-domain/index.tspackages/analytics-js/src/services/StoreManager/storages/sessionStorage.tspackages/analytics-js/src/services/StoreManager/storages/defaultOptions.tspackages/analytics-js/src/services/ErrorHandler/ErrorHandler.tspackages/analytics-js/src/components/utilities/page.tspackages/analytics-js/src/components/utilities/globals.tspackages/analytics-js/src/components/userSessionManager/UserSessionManager.tspackages/analytics-js/src/components/preloadBuffer/index.tspackages/analytics-js/src/components/eventRepository/EventRepository.tspackages/analytics-js/src/components/eventManager/utilities.tspackages/analytics-js/src/app/RudderAnalytics.tspackages/analytics-js/src/components/capabilitiesManager/detection/storage.tspackages/analytics-js/src/components/capabilitiesManager/detection/browser.tspackages/analytics-js/src/components/capabilitiesManager/CapabilitiesManager.tspackages/analytics-js/__tests__/nativeSdkLoader.jspackages/analytics-js/src/components/capabilitiesManager/detection/screen.tspackages/analytics-js/src/components/capabilitiesManager/detection/dom.tspackages/analytics-js/src/components/core/utilities.tspackages/analytics-js/src/components/core/Analytics.tspackages/loading-scripts/src/index.tspackages/analytics-js/__tests__/components/utilities/page.test.tspackages/analytics-js-cookies/src/component-cookie/index.tspackages/analytics-js-cookies/__tests__/cookieUtilities.test.tspackages/analytics-js-plugins/src/oneTrustConsentManager/index.tspackages/analytics-js-plugins/src/utilities/retryQueue/Schedule.tspackages/analytics-js-plugins/src/utilities/retryQueue/RetryQueue.tspackages/analytics-js-plugins/src/errorReporting/utils.tspackages/analytics-js-plugins/src/googleLinker/base64Decoder.tspackages/analytics-js-plugins/src/deviceModeDestinations/utils.tspackages/analytics-js-plugins/__tests__/errorReporting/utils.test.tspackages/analytics-js-plugins/src/ketchConsentManager/index.tspackages/analytics-js-plugins/src/bugsnag/utils.tspackages/analytics-js-plugins/__tests__/bugsnag/utils.test.tspackages/analytics-js-common/src/v1.1/utils/storage/v3DecryptionUtils.jspackages/analytics-js-common/src/services/ExternalSrcLoader/jsFileLoader.tspackages/analytics-js-common/src/utilities/url.tspackages/analytics-js-common/src/utilities/string.tspackages/analytics-js-common/src/utilities/page.tsassets/integrations/AdobeAnalytics/adobe-analytics-js.jspackages/analytics-js-common/src/utilities/crypto.tsassets/integrations/AdobeAnalytics/adobe-analytics-js-heartbeat.jsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `globalThis` are correctly handled. # Test: Search for references to `globalThis`. Expect: Correct usage across the codebase. rg --type javascript -A 5 $'globalThis'Length of output: 73
Script:
#!/bin/bash # Description: Verify all references to `globalThis` are correctly handled. # Test: Search for references to `globalThis` in JavaScript and TypeScript files. rg --glob '*.js' --glob '*.jsx' --glob '*.ts' --glob '*.tsx' -A 5 'globalThis'Length of output: 362893
PR Description
Fixed the custom
globalThispolyfill in the loading snippet.Linear task (optional)
https://linear.app/rudderstack/issue/SDK-2239/update-globalthis-polyfill-for-safari-browsers
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
Documentation
New Features
globalThisacross various JavaScript files, ensuring safer, more robust global context assignments without modifyingObject.prototype. This improves compatibility and reduces potential side effects.These changes collectively enhance user experience by providing clearer documentation and a more reliable integration method for developers.