Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade storejs lib and remove the patch #1700

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Apr 23, 2024

PR Description

Upgrade storejs lib to the latest version and remove the patch.

Linear task (optional)

https://linear.app/rudderstack/issue/SDK-1713/remove-storejs-patch

Cross Browser Tests

Please confirm you have tested for the following browsers:

  • Chrome
  • Firefox
  • IE11

Sanity Suite

  • All sanity suite test cases pass locally

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Summary by CodeRabbit

  • Chores
    • Updated the storejs library to enhance performance and stability.

@MoumitaM MoumitaM requested a review from a team as a code owner April 23, 2024 05:26
Copy link
Contributor

coderabbitai bot commented Apr 23, 2024

Walkthrough

The update primarily involves a minor version upgrade of the storejs library in the package.json file, shifting from version 2.0.7 to 2.1.0. This change suggests improvements or new features in the dependency without breaking existing functionality.

Changes

File Change Summary
package.json Updated storejs from 2.0.7 to 2.1.0

🐰✨📦
A hop, a skip, in the code we dip,
storejs got a bump, let's not trip.
From 2.0.7 to 2.1.0, it's a small leap,
Ensuring our storage is robust and deep.
Celebrate the change, for progress we reap! 🎉


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 695b229 and 0455a18.
Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing (1)
  • package.json (1 hunks)
Additional comments not posted (1)
package.json (1)

71-71: Version of storejs updated from 2.0.7 to 2.1.0.

Ensure compatibility with the rest of the project and verify that all functionalities work as expected with the new library version.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.92%. Comparing base (695b229) to head (0455a18).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1700   +/-   ##
========================================
  Coverage    53.92%   53.92%           
========================================
  Files          461      461           
  Lines        15615    15615           
  Branches      3101     3090   -11     
========================================
  Hits          8421     8421           
- Misses        5890     5928   +38     
+ Partials      1304     1266   -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Common Code - No bundling 15.78 KB 15.78 KB (0%) 16.5 KB
Remote Module Federation Mapping - CDN 330 B 330 B (0%) 512 B
Remote Module Federated Plugins - CDN 5.71 KB 5.71 KB (0%) 6 KB
Core ESM - NPM 7.66 KB 7.66 KB (0%) 8 KB
Core CJS - NPM 22.47 KB 22.47 KB (0%) 23 KB
Core - NPM 22.56 KB 22.56 KB (0%) 23 KB
Core Legacy - CDN 43 KB 43 KB (0%) 44 KB
Core - CDN 22.71 KB 22.71 KB (0%) 23 KB
Core (legacy build) - CDN - v1.1 31.57 KB 31.57 KB (0%) 32 KB
Core - NPM - v1.1 31.56 KB 31.56 KB (0%) 32 KB
Service Worker Module 22.64 KB 22.64 KB (0%) 24 KB
All Integrations (legacy build) - CDN 98.4 KB 98.4 KB (0%) 105 KB

@MoumitaM MoumitaM merged commit ba33b9e into develop Apr 23, 2024
10 checks passed
@MoumitaM MoumitaM deleted the feature/sdk-1713-remove-storejs-patch branch April 23, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants