Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting add to cart for criteo #1696

Merged
merged 3 commits into from
Apr 25, 2024
Merged

feat: supporting add to cart for criteo #1696

merged 3 commits into from
Apr 25, 2024

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Apr 18, 2024

PR Description

Adding Add To Cart event support for criteo.
ref:
https://help.criteo.com/kb/guide/en/intro-to-the-criteo-onetag-8fjCDwCENw/Steps/775595,853887,2616497,2616569,2616738,2617589,2617588,2617271,2617274,2617282,2617302#:~:text=The%20%22Criteo%20Add%20to%20Cart%20Tag%22

Linear task (optional)

Resolves INT-2007

Cross Browser Tests

Please confirm you have tested for the following browsers:

  • Chrome
  • Firefox
  • IE11

Sanity Suite

  • All sanity suite test cases pass locally

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Summary by CodeRabbit

  • New Features

    • Added support for tracking 'product added' events in analytics.
  • Improvements

    • Changed certain log messages from 'error' to 'warn' to better reflect the severity of issues.

@shrouti1507 shrouti1507 added the enhancement New feature or request label Apr 18, 2024
@shrouti1507 shrouti1507 self-assigned this Apr 18, 2024
Copy link
Contributor

coderabbitai bot commented Apr 18, 2024

Walkthrough

The recent update enhances the Criteo integration in the analytics JavaScript package by adding support for the 'product added' event, adjusting log message severity levels, and introducing new utility functions for managing product additions efficiently.

Changes

File Path Changes
.../constants/integrations/Criteo/constants.ts Added 'product added' to the supportedEvents constant array.
.../integrations/Criteo/browser.js Changed logging level for certain messages from error to warn; added handling for 'product added' event in the handleEvent method.
.../integrations/Criteo/utils.js Updated log messages from error to warn; added handleProductAdded function to manage adding products to the cart; exported getProductInfo and handleProductAdded functions.
.../integrations/__tests__/integrations/Criteo/utils.test.js Added utils.test.js file in the Criteo integration tests suite with test cases for the handleProductAdded function covering property extraction, error handling, 'addToCart' object creation, product object addition, and missing 'currency' property handling.

🐇🌟
A hop, a skip, a code deploy,
In the land of tech, oh what a joy!
'Product added' now on the list,
With logs less stern, no more a twist.
Cheers to the devs, with carrots to enjoy! 🥕🎉
🐇🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 53.96%. Comparing base (3543cc1) to head (5648af3).

Files Patch % Lines
...js-integrations/src/integrations/Criteo/browser.js 0.00% 5 Missing ⚠️
...s-js-integrations/src/integrations/Criteo/utils.js 66.66% 4 Missing ⚠️
...mon/src/constants/integrations/Criteo/constants.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1696      +/-   ##
===========================================
+ Coverage    53.93%   53.96%   +0.03%     
===========================================
  Files          461      461              
  Lines        15616    15626      +10     
  Branches      3089     3109      +20     
===========================================
+ Hits          8422     8433      +11     
+ Misses        5928     5841      -87     
- Partials      1266     1352      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 18, 2024

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Common Code - No bundling 15.78 KB 15.78 KB (0%) 16.5 KB
Remote Module Federation Mapping - CDN 330 B 330 B (0%) 512 B
Remote Module Federated Plugins - CDN 5.71 KB 5.71 KB (0%) 6 KB
Core ESM - NPM 7.66 KB 7.66 KB (0%) 8 KB
Core CJS - NPM 22.47 KB 22.47 KB (0%) 23 KB
Core - NPM 22.56 KB 22.56 KB (0%) 23 KB
Core Legacy - CDN 43 KB 43 KB (0%) 44 KB
Core - CDN 22.71 KB 22.71 KB (0%) 23 KB
Core (legacy build) - CDN - v1.1 31.57 KB 31.57 KB (0%) 32 KB
Core - NPM - v1.1 31.56 KB 31.56 KB (0%) 32 KB
Service Worker Module 22.64 KB 22.64 KB (0%) 24 KB
All Integrations (legacy build) - CDN 98.48 KB 98.67 KB (+0.2% ▲) 105 KB

Copy link

@shrouti1507 shrouti1507 merged commit bb7e1df into develop Apr 25, 2024
9 checks passed
@shrouti1507 shrouti1507 deleted the enhance.criteo branch April 25, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants