-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supporting add to cart for criteo #1696
Conversation
WalkthroughThe recent update enhances the Criteo integration in the analytics JavaScript package by adding support for the 'product added' event, adjusting log message severity levels, and introducing new utility functions for managing product additions efficiently. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1696 +/- ##
===========================================
+ Coverage 53.93% 53.96% +0.03%
===========================================
Files 461 461
Lines 15616 15626 +10
Branches 3089 3109 +20
===========================================
+ Hits 8422 8433 +11
+ Misses 5928 5841 -87
- Partials 1266 1352 +86 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
Quality Gate passedIssues Measures |
PR Description
Adding Add To Cart event support for criteo.
ref:
https://help.criteo.com/kb/guide/en/intro-to-the-criteo-onetag-8fjCDwCENw/Steps/775595,853887,2616497,2616569,2616738,2617589,2617588,2617271,2617274,2617282,2617302#:~:text=The%20%22Criteo%20Add%20to%20Cart%20Tag%22
Linear task (optional)
Resolves INT-2007
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
New Features
Improvements