chore: address sonar issues

rudderlabs · Jan 24, 2025 · 86f5bf4 · 86f5bf4
1 parent bf89963
commit 86f5bf4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/packages/analytics-js-common/src/utilities/retryQueue/RetryQueue.ts b/packages/analytics-js-common/src/utilities/retryQueue/RetryQueue.ts
@@ -412,9 +412,8 @@ class RetryQueue implements IQueue<QueueItemData> {
    * Adds an item to the retry queue
    *
    * @param {Object} qItem The item to process
-   * @param {Error} [error] The error that occurred during processing
    */
-  requeue(qItem: QueueItem<QueueItemData>, error?: Error) {
+  requeue(qItem: QueueItem<QueueItemData>) {
     const { attemptNumber, item, type, id } = qItem;
     // Increment the attempt number as we're about to retry
     const attemptNumberToUse = attemptNumber + 1;
@@ -487,7 +486,7 @@ class RetryQueue implements IQueue<QueueItemData> {
       this.setStorageEntry(IN_PROGRESS, inProgress);
 
       if (err) {
-        this.requeue(el, err);
+        this.requeue(el);
       }
     };
 

diff --git a/packages/analytics-js/src/app/RudderAnalytics.ts b/packages/analytics-js/src/app/RudderAnalytics.ts
@@ -17,7 +17,6 @@ import {
 } from '@rudderstack/analytics-js-common/types/LoadOptions';
 import type { ApiCallback, ApiOptions } from '@rudderstack/analytics-js-common/types/EventApi';
 import type { ApiObject } from '@rudderstack/analytics-js-common/types/ApiObject';
-import { RSA } from '@rudderstack/analytics-js-common/constants/loggerContexts';
 import type { IdentifyTraits } from '@rudderstack/analytics-js-common/types/traits';
 import { generateUUID } from '@rudderstack/analytics-js-common/utilities/uuId';
 import { onPageLeave } from '@rudderstack/analytics-js-common/utilities/page';

diff --git a/packages/analytics-js/src/state/slices/dataPlaneEvents.ts b/packages/analytics-js/src/state/slices/dataPlaneEvents.ts
@@ -1,6 +1,5 @@
 import { signal } from '@preact/signals-core';
 import type { DataPlaneEventsState } from '@rudderstack/analytics-js-common/types/ApplicationState';
-import type { PluginName } from '@rudderstack/analytics-js-common/types/PluginsManager';
 
 const dataPlaneEventsState: DataPlaneEventsState = {
   deliveryEnabled: signal(true), // Delivery should always happen