Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename advertiserId to pixelId for reddit pixel #1239

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Gauravudia
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • I have executed schemaGenerator tests and updated schema if needed

  • Are sensitive fields marked as secret in definition config?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (hotfix/26th.Feb@bd8315a). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             hotfix/26th.Feb     #1239   +/-   ##
===================================================
  Coverage                   ?   100.00%           
===================================================
  Files                      ?         2           
  Lines                      ?        53           
  Branches                   ?         7           
===================================================
  Hits                       ?        53           
  Misses                     ?         0           
  Partials                   ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia merged commit 8c8dd78 into hotfix/26th.Feb Feb 27, 2024
8 checks passed
@Gauravudia Gauravudia deleted the chore/redditPixel branch February 27, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants