feat: add v2 toggle for google ads for ecom spec support #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashasvibajpai
requested review from
lvrach,
cisse21,
nidhilashkari17,
debanjan97,
ssbeefeater,
AchuthaSourabhC,
ruchiramoitra,
ashishRudder,
ItsSudip,
shrouti1507,
sandeepdsvs,
krishna2020,
desusai7,
1abhishekpandey and
bardisg
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1204 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 53
Branches 7 7
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
ItsSudip
approved these changes
Feb 21, 2024
aashishmalik
approved these changes
Feb 28, 2024
yashasvibajpai
deleted the
feat.googleads.ecom.spec.support.v2.config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
We will be driving support for RudderStack's standard ecom spec for Google Ads destination's track event through this UI toggle (enabled by default). This PR addresses the change.
What is the related Linear task?
Resolves INT-1573
Please explain the objectives of your changes below
We are providing backward compatibility to old event structure, so that any existing functionalities do not have a breaking change, as the event structure and properties would be modified.
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
Newly created destinations will have this toggle enabled, so the track events follow the RudderStack Standard Ecom spec.
Any new dependencies introduced with this change?
A toggle, enabled by default. To revert to older flow, disable the toggle.
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.