Skip to content

Commit

Permalink
chore: add custom domain url labels for gtm and ga4 (#1867)
Browse files Browse the repository at this point in the history
  • Loading branch information
yashasvibajpai authored Jan 24, 2025
1 parent fed05fa commit f570d03
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/configurations/destinations/ga4/ui-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,11 @@
],
"condition": "or"
},
"label": "SDK Base URL",
"label": "Custom Domain URL",
"configKey": "sdkBaseUrl",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$",
"regexErrorMessage": "Please input a valid URL.",
"note": "Enter your GA4 SDK base URL, https://{SDK Base URL}/gtag/js. By default, it is https://www.googletagmanager.com.",
"note": "Enter your GA4 Custom Domain URL, https://{Custom Domain URL}/gtag/js. By default, it is https://www.googletagmanager.com.",
"placeholder": "e.g: https://www.example.com",
"default": "https://www.googletagmanager.com",
"secret": false
Expand Down
2 changes: 1 addition & 1 deletion src/configurations/destinations/gtm/ui-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
{
"type": "textInput",
"label": "Server Container URL",
"label": "Custom Domain URL",
"value": "serverUrl",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$",
"regexErrorMessage": "Invalid URL",
Expand Down

0 comments on commit f570d03

Please sign in to comment.