Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lib/json/ext/generator/state.rb to the gemspec #635

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

eregon
Copy link
Member

@eregon eregon commented Oct 21, 2024

  • Otherwise the gem always uses the pure-Ruby backend as it's missing that file and rescuing the LoadError.

It'd be great to have some tests with the installed gem or so, but I don't have time to add that (at least not now).

@eregon eregon requested a review from byroot October 21, 2024 19:39
* Otherwise the gem always uses the pure-Ruby backend
  as it's missing that file and rescuing the LoadError.
@byroot
Copy link
Member

byroot commented Oct 21, 2024

Ouch good catch.

Maybe we should just move to a glob like most gems.

@byroot byroot merged commit ac68b8c into ruby:master Oct 21, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants