Make OpenStruct support as optional #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
2 tasks
sharshenov
added a commit
to sharshenov/hutch
that referenced
this pull request
May 7, 2024
`OpenStruct` is optional since `JSON` v 2.7.2 References: - ruby/json#565 - https://github.com/ruby/ostruct/blob/master/lib/ostruct.rb#L136 This commit fixes error: ``` Hutch.connect gems/hutch-1.2.0/lib/hutch/broker.rb:272:in `api_config': uninitialized constant Hutch::Broker::OpenStruct (NameError) @api_config ||= OpenStruct.new.tap do |config| ^^^^^^^^^^ ```
fidel
added a commit
to RailsEventStore/rails_event_store
that referenced
this pull request
Dec 31, 2024
Since Ruby 3.5 ostruct won't come as bundled gem, it's currently triggering warning in projects using RailsEventStore as it's required in PreserveTypes: - #1824 - https://bugs.ruby-lang.org/issues/20309 - ruby/json#565 We don't rely on OpenStruct, but just support it being present in events' data and metadata. RailsEventStore::JSONClient has been modified to support OpenStruct only if it's present in project's bundle — we assume that if someone made a decision to use this library, it was an informed decision. Still, it has to become development dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/ruby/ostruct/blob/master/lib/ostruct.rb#L136
OpenStructis not recommend to use with performance reason today. We should makeOpenStructsupport as optional.