Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add socket_class while instantiating net_ldap connection #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhivyada
Copy link

No description provided.

Copy link
Contributor

@jethrodaniel jethrodaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net-ldap-0.16.2.gem was accidentally committed

@dhivyada
Copy link
Author

Removed the accidentally committed gem. Thank you for the feedback

@dhivyada dhivyada force-pushed the adds_socket_class_flag branch from 27b8c15 to b8b9042 Compare May 15, 2020 03:53
@dhivyada
Copy link
Author

@jethrodaniel : Force pushed the socket changes alone to keep the commit history clean

@michaelfranzl
Copy link

This is a very useful feature IMO. This would allow a socket to be configured beyond the connection timeout, e.g. by binding it to a specific local interface and port. Are there plans to merge this?

@zeroSteiner zeroSteiner self-assigned this Dec 7, 2024
zeroSteiner added a commit that referenced this pull request Dec 7, 2024
…onnection

Ability to add socket_class while instantiating net_ldap connection
@zeroSteiner
Copy link
Collaborator

zeroSteiner commented Dec 7, 2024

I merged this into a testing branch to run the CI test suite and got a bunch of failures. I think the best path forward on this would be to rebase the changes onto master and then get the tests passing. Once that's done I can test this with a custom socket class and get this landed. Thanks!

Edit: Well GitHub now has a fancy button to easily rebase these changes ontop of master so I went ahead and did that for you so we can see the tests that are failing. I hope you don't mind, but it will affect your branch.

@zeroSteiner zeroSteiner force-pushed the adds_socket_class_flag branch from b8b9042 to dfe625e Compare December 7, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants