Avoid error when member is present on ancestor class #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niche case - when clearing class members for new definition, avoid trying to remove members present on ancestor classes.
francesmcmullin
force-pushed
the
fix-padrino-compat
branch
from
66ab6f7 to
bc930ab
Compare
eregon
reviewed
Oct 16, 2024
spec/concurrent/struct_shared.rb
Outdated
| @@ -26,6 +26,18 @@ | |||
| expect(clazz.ancestors).to include described_class | |||
| end | |||
|
|
|||
| it 'ignores methods on ancestor classes' do | |||
| ancestor = described_class.ancestors.first | |||
There was a problem hiding this comment.
described_class.ancestors.first is the same as described_class, no?
Unless prepended modules are involved here?
There was a problem hiding this comment.
Good catch! I double checked and it works as well using ancestors.last 👍🏻
eregon
reviewed
Oct 16, 2024
spec/concurrent/struct_shared.rb
Outdated
Comment on lines
33
to
36
| clazz = described_class.new(:foo) | ||
| expect{ described_class.const_get(clazz.to_s) }.to raise_error(NameError) | ||
| expect(clazz).to be_a Class | ||
| expect(clazz.ancestors).to include described_class |
There was a problem hiding this comment.
This seems not meaningful to test here, let's just that that creating an instance of it plus accessing that member works as expected.
francesmcmullin
force-pushed
the
fix-padrino-compat
branch
from
e4e1d20 to
3a775c4
Compare
|
I've updated the spec now based on comments - the ancestor method is added to the end of the ancestor chain, and I'm testing the more relevant method presence and arity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1067
Niche case - when clearing class members for new definition, avoid trying to remove members present on ancestor classes.
I'm happy to make any updates for style or structure if needed - I've added a spec that does fail without this fix, very happy to receive feedback if it would fit better in a different location or with different emphasis.