Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): avoid loading json 2.7.0 #12504

Closed
wants to merge 1 commit into from
Closed

build(deps): avoid loading json 2.7.0 #12504

wants to merge 1 commit into from

Conversation

Uaitt
Copy link
Contributor

@Uaitt Uaitt commented Dec 4, 2023

Avoid loading release 2.7.0 of the json gem as it contains a backward-compatibility issue.

(Basically, on 2.7.0 you can't do JSON.dump(a:1, b:2, c:3) but you need to do JSON.dump({ a:1, b:2, c:3 })

Refrences:


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@Uaitt
Copy link
Contributor Author

Uaitt commented Dec 4, 2023

Not sure if I should add a Changelog entry for this 🤔

@koic
Copy link
Member

koic commented Dec 4, 2023

Tests for RuboCop pass with the matrix of JSON 2.7.0 and Ruby 2.7, and it works. This means that instead of avoiding the version of JSON on the RuboCop side, it seems best to handle it on applications and client side. Thank you.

@koic koic closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants