Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude MRI head and old rubocop from CI matrix #74

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Exclude MRI head and old rubocop from CI matrix #74

merged 1 commit into from
Jan 10, 2025

Conversation

viralpraxis
Copy link
Collaborator

No description provided.

@viralpraxis viralpraxis self-assigned this Jan 10, 2025
@viralpraxis
Copy link
Collaborator Author

I thinking about simplifying CI to test against single rubocop version, just like how other plugins do

see also #54

@viralpraxis viralpraxis merged commit 9f86764 into rubocop:master Jan 10, 2025
22 checks passed
@viralpraxis viralpraxis deleted the exclude-ruby-3-5-and-old-rubocop-from-ci-matrix branch January 10, 2025 20:13
@viralpraxis
Copy link
Collaborator Author

I thinking about simplifying CI to test against single rubocop version, just like how other plugins do

see also #54

@mikegee What do you think? I've recently merged some PRs to "unify" rubocop-thread_safety with other plugins, this idea feels like proper development of this process.

@mikegee
Copy link
Collaborator

mikegee commented Jan 12, 2025

Love it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@viralpraxis viralpraxis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viralpraxis @mikegee