Merge pull request #319 from nonpop/fix-string-diff-stack-overflow

Make makeChangesHelp tail recursive
rtfeldman · Nov 19, 2018 · 8171975 · 8171975
2 parents dfdb0b7 + 74a7736
commit 8171975
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/Test/Runner/Node/Vendor/Diff.elm b/src/Test/Runner/Node/Vendor/Diff.elm
@@ -213,11 +213,12 @@ makeChangesHelp changes getA getB ( x, y ) path =
                     else
                         Err (UnexpectedPath ( x, y ) path)
             in
-            change
-                |> Result.andThen
-                    (\c ->
-                        makeChangesHelp (c :: changes) getA getB ( prevX, prevY ) tail
-                    )
+            case change of
+                Err err ->
+                    Err err
+
+                Ok c ->
+                    makeChangesHelp (c :: changes) getA getB ( prevX, prevY ) tail