Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests : Add tests for Core Quote block. #23

Merged
merged 17 commits into from
Sep 26, 2024
Merged

tests : Add tests for Core Quote block. #23

merged 17 commits into from
Sep 26, 2024

Conversation

Ta5r
Copy link
Collaborator

@Ta5r Ta5r commented Sep 20, 2024 •
edited by justlevine
Loading

Tracking wpengine#299

What:

This PR backfills tests for the Core Quote block and its attributes.

Tested attributes :

  • anchor
  • backgroundColor
  • citation
  • className
  • cssClassName
  • fontFamily
  • fontSize
  • gradient
  • layout
  • lock
  • style
  • textAlign
  • textColor
  • value

Untested fields:

  • CoreQuoteAttributes.metadata - @todo

Exposed issues:

NA

@Ta5r Ta5r self-assigned this Sep 20, 2024
@Ta5r Ta5r requested a review from justlevine September 20, 2024 17:13
@Ta5r
tests: add tests for CoreQuote
6d97815 
This was reset and cherrypicked to undo the bad merges/rebases

Co-authored-by: Ta5r <[email protected]>
justlevine
justlevine requested changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#24 (review)

@Ta5r Ta5r requested a review from justlevine September 23, 2024 15:53
@Ta5r Ta5r requested a review from justlevine September 23, 2024 20:57
justlevine
justlevine reviewed Sep 24, 2024
View reviewed changes
tests/unit/CoreQuoteTest.php Outdated
Comment on lines 153 to 154
'layout' => null,
'textAlign' => null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed these from the query entirely, so they should be removed here, not exiting with a value of null (ref: https://github.com/rtCamp/wp-graphql-content-blocks/actions/runs/11011696682/job/30576344056?pr=23#step:8:282)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yupp, i justt figured that out 😓

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to comment them out, just remove them.

@Ta5r Ta5r requested a review from justlevine September 24, 2024 14:23
justlevine
justlevine reviewed Sep 24, 2024
View reviewed changes
.changeset/thirty-chicken-drum.md Outdated
"@wpengine/wp-graphql-content-blocks": patch
---

test : Core Quote block fields and attributes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this

justlevine
justlevine requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last two unresolved comments, then go ahead and open it up on WPE.

@justlevine justlevine marked this pull request as ready for review September 24, 2024 14:56
justlevine
justlevine approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and open this on WPE 🙌

@justlevine justlevine added the has-upstream-pr A PR has been opened against wpengine's repo label Sep 24, 2024
@justlevine justlevine merged commit 9f44523 into main Sep 26, 2024
10 checks passed
@justlevine justlevine deleted the core-quote-test branch October 18, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justlevine justlevine justlevine approved these changes

Assignees

@Ta5r Ta5r

Labels
has-upstream-pr A PR has been opened against wpengine's repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ta5r @justlevine