Return hasht when rebuilding from load data #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test cases that depends on the fix.
matsl
force-pushed
the
add-referent-save-and-restore-tests
branch
from
2315a9c to
a78795a
Compare
rswgnu
requested changes
Feb 7, 2025
test/hywiki-tests.el
Outdated
| (hy-delete-dir-and-buffer hywiki-directory)))) | ||
|
|
||
| (ert-deftest hywiki-tests--save-referent-use-hyperbole-menu () | ||
| "Verify saving and loading a referent works when using Hyperboles menu." |
matsl
commented
Feb 7, 2025
test/hywiki-tests.el
Outdated
| (ert-deftest hywiki-tests--save-referent-use-hyperbole-menu () | ||
| "Verify saving and loading a referent works when using Hyperboles menu." | ||
| :expected-result :failed | ||
| ;; The entered key series is inserted into the WikiWord file. |
There was a problem hiding this comment.
I don’t understand the expected fail. Are you showing that you found an issue with key series as a referent that your hasht fix does not resolve? If so, you should also comment the code with the problem rather than just letting the failed test demonstrate it, for my small mammalian brain.
Here is the comment that tries to explain it but I can move it down to the should check that fails.
rswgnu
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Return hasht when rebuilding from load data and add test cases that
depends on the fix.
Why
The result of hywiki-make-referent-hasht is used as a hash table in
some case so it is important that the new value is returned.
The successful test case depends on this change.
The expected failed test case illustrates that the key series is
inserted in the buffer as well as in the definition of the
referent. This can be shown manually too so it does not only happen in
the test case. This test case is only activated when run interactively
like test-all.