Suppress byte compile warnings calling org-id-get #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Later version of org added a fourth argument that we want to use if available.
rswgnu
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Suppress byte compile warnings for calling org-id-get with different
number of args
Why
Later version of org added a fourth argument that we want to use if
available.
Note
Warning has been removed from 29.4 build
Uses hypb:with-suppressed-warnings as we are using that in another
place. The comment in the functions hints that it is a requirement due
to Emacs 26 being used in ELPA or for ELPA compatibility. The change
comes from 2022 so I would think that it is not required
anymore. Especially since Hyperbole can't be byte compiled nor used
without byte compilation using Emacsen earlier than Emacs 27!?