Matsl rsw remove unused function #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests are failing; Mats, see if you can fix them.
Make hyrolo cache variables buffer-local to allow multiple commands
to have their own hyrolo display buffers.
Fix hyrolo-logic.el to handle multiple file formats (not yet tested).
test/hyrolo-tests.el (hyrolo-demo-move-to-beginning-and-end-of-file):
Move to {,} and {.} tests to sep test.
kotl-mode - Fix check of 'kotl-previous-mode' to not set local vars if prior mode was the same, i.e. kotl-mode.
Fix HyRolo file wildcard handling in hpath:expand-list.
(hyrolo-to-entry-end): Remove unused arg '_curr-entry-level-len'. (hyrolo-grep-file): Remove unneeded passing of 'curr-entry-level-len' arg to (hyrolo-outline-previous-visible-heading, hyrolo-next-visible-heading): Fix doc strings to mention stops at match buffer headers.
hibtypes.el (Info-node): Tighten match to limit valid chars after closing paren.
(hyrolo-stuck-msg): Add to jump to the position where a HyRolo match
became stuck, if ever happens, when point is on the error.
hyrolo.el (hyrolo-grep-file): Update 'Stuck looping in buffer' msg so can be
used in new 'hyrolo-stuck-msg' ibtype.
man/hyperbole.texi (Implicit Button Types): Add doc for 'hib-python-traceback'
and 'hyrolo-stuck-msg'.
hyperbole.el: The 'describe-package' function fails under Emacs 28 when multiple
maintainers are listed under the 'Maintainer' header but later Emacs versions
support a 'Maintainers' header, so include both. Change to using 'Authors'
Will also install the markdown-mode package as necessary when a Markdown file is specified in 'hyrolo-file-list'. This fixes failures with Markdown files improperly put into fundamental-mode which means their headings are not recognized properly. hload-path.el (auto-mode-alist): Setup to invoke 'outline-mode' on ".otl" suffixed files. man/hyperbole.texi (HyRolo Concepts): hyrolo.el (hyrolo-file-list): Update doc to specify allowable file suffixes and types.
Fix 'hpath--expand-auto-variable-alist' and 'hpath--resolve-auto-variable-alist' tests.
In same keymap, fix , and . movement keys. For all supported HyRolo major modes, include file headers in both hyrolo-hdr-regexp and outline-regexp.
Disable reveal-mode until can get it to work properly with outline-minor-mode. Fix hyrolo-tests.el tests that prompt to re-read-in files.
Note discrepancies from expected behavior are added as comments.
Matsl rsw hui link possible types
This avoids the query for the local vars when the tests are run interactively.
Set enable-local-variables to nil for tests with DEMO and FAST-DEMO
hmouse-alist-add-window-handlers - Default to implicit button creation; create explicit button with C-u prefix.
Add example of ERT test action buttons to DEMO, FAST-DEMO and the manual. Add ERT test action button support for ert-deftext-async definitions from the "ert-async.el" package. Fix smart-lisp tag finding to exclude outside <> chars when are part of action buttons. Fix text-toc actype to only match to given text at the start of a heading.
Fix to repair mixed version Org installation so Hyperbole works by calling new function `hsys-org-fix-version' from `hyperb:init'.
Add tests for non file ebut creation and deletion
…nd-backwards-using-multi-file-and-depth-structure Add tests with more file types and outline structure depth
smart-hyrolo - extend to edit source files from anywhere in header
Fix byte-compiler warnings
Conditionally define `string-replace' for Emacs27 compatibility
…interactive Remove skip guard on test that works in batch mode
This reverts commit 89b2477. This change did not work out in CI/CD nor running locally in docker. Reverting to keep rsw branch healthy.
Only require package-lint in the package-lint target. The compat library that was dragged in due to package-lint resolved backwards compatibility for string-replace for older Emacs versions. Solved here by using older replace-regexp-in-string.
…pendencies Remove package-lint dependency and string-replace compatibility code
* Add test for hargs:sexpression-p * Fix hargs:sexpression-p when eval triggers an error Add test hargs-tests--sexpression-p
* Cleanup of flycheck/flymake info and warning messages * Fix remaining doc strings to eliminate flycheck warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove unused function
Why
Extracted into a separate commit and PR for observability and easier traceability.