Add tests for hywconfig #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsl
force-pushed
the
add-hywconfig-tests
branch
from
d26df68 to
5fe6999
Compare
matsl
commented
Dec 7, 2023
| (ert-deftest hywconfig--add-by-name () | ||
| "Verify config is added by name." | ||
| :expected-result :failed | ||
| ;; See backtrace for the error - (wrong-type-argument listp #<window-configuration>) |
There was a problem hiding this comment.
It looks like this is the error. set:member gets a list instead of a single window-config!? Sounds related to the error in the current TODOs.
Both failing test cases are set with :expected-result :failed to not break the CI-build and make it easier to merge the PR for later updates related to the error. i.e. if you approve of the tests they can go in and then we can work on the fix in a separate PR.
rswgnu
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add tests for hywconfig.
Why
This has not been covered before and there is a bug with restoring named configs.