Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Run yarn install if either build or test are needed #42

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: Run yarn install if either build or test are needed #42

merged 1 commit into from
Jan 9, 2025

Conversation

gadenbuie
Copy link
Member

@gadenbuie gadenbuie commented Jan 9, 2025 •
edited
Loading

Fixes an issue with the routine workflow where currently yarn install is only run if yarn build is needed. If yarn build isn't needed but yarn test is, then testing will fail because the install step was skipped. (Example failing workflow run)

This PR moves yarn install to it's own step that's run if either build or test are needed.

@gadenbuie gadenbuie requested a review from schloerke January 9, 2025 14:53
schloerke
schloerke approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@schloerke schloerke merged commit 706338f into main Jan 9, 2025
1 check passed
@schloerke schloerke deleted the fix/yarn-install-separately branch January 9, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadenbuie @schloerke