Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing paren #10

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Add missing paren #10

merged 1 commit into from
Jan 6, 2023

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Jan 6, 2023 •
edited
Loading

Seeing an error in CI (e.g. https://github.com/rstudio/shiny/actions/runs/3851754436/jobs/6563259010):

Error: Error: unexpected symbol in:
"      system(paste0("echo 'path=", phantom_path, "' >> $GITHUB_OUTPUT'")
      found"
Execution halted

@jcheng5 jcheng5 requested a review from schloerke January 6, 2023 01:30
schloerke
schloerke approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@schloerke
Copy link
Collaborator

Once merged, force tag with tag name "v1" and push the new tag value

@jcheng5 jcheng5 merged commit 6d23bf3 into main Jan 6, 2023
@jcheng5 jcheng5 deleted the missing-paren branch January 6, 2023 01:34
@Abinashbunty
Copy link

I had put this in #9 😄 But it's fine.

@schloerke schloerke mentioned this pull request Jan 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcheng5 @schloerke @Abinashbunty