Use new version of has_crop_tools() from knitr
#2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It handles new windows specificity regarding ghostscript Context at yihui/knitr#2246
cderv
force-pushed
the
knitr-pdf-crop
branch
from
4e56ebc to
ce7e825
Compare
yihui
reviewed
Dec 11, 2023
There was a problem hiding this comment.
- Should it be exported from knitr instead ?
- Should we inline instead to replace the one in rmarkdown completely ?
- Or is it old enough so that we bump knitr min requirement ?
I think it's fine to use ::: (CRAN allows for it when the maintainer is the same for the two packages) and not export it from knitr.
I'm also okay with requiring knitr >= 1.43. In theory, when users install the new version of rmarkdown, knitr should be updated automatically if we specify this version requirement. In practice, I did see (rare) cases in which the version requirement was bypassed, but I have never understood how it was possible.
|
Ok I went with the dependency upgrade. I did not use the function directly. Not sure if any of our others tools is using We could have re-export but don't think that works with internal function as I would have done #' @importFrom knitr has_crop_tools
#' @export
knitr::has_crop_tools |
yihui
approved these changes
Dec 11, 2023
…should be unlikely but still) [ci skip]
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Dec 19, 2023
Merge remote-tracking branch 'rstudio/main' into jg-tree-fix * rstudio/main: Use new version of `has_crop_tools()` from knitr (rstudio#2532) some cosmetic changes use ignore.case = TRUE for regex functions instead of enumerating upper/lowercase letters Remove `stringr` dependency (rstudio#2530) Add a mention about required configuration when erroring about webshot and webshot2 # Conflicts: # NEWS.md
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Dec 19, 2023
Merge remote-tracking branch 'rstudio/main' into jg-devel * rstudio/main: Use new version of `has_crop_tools()` from knitr (rstudio#2532) some cosmetic changes use ignore.case = TRUE for regex functions instead of enumerating upper/lowercase letters Remove `stringr` dependency (rstudio#2530) Add a mention about required configuration when erroring about webshot and webshot2 # Conflicts: # NEWS.md
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Dec 19, 2023
Merge branch 'jg-devel' * jg-devel: Use new version of `has_crop_tools()` from knitr (rstudio#2532) some cosmetic changes use ignore.case = TRUE for regex functions instead of enumerating upper/lowercase letters Remove `stringr` dependency (rstudio#2530) Add a mention about required configuration when erroring about webshot and webshot2 Fixed documentation problems with `publish_site()` # Conflicts: # R/publish_site.R
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We improved the logic in knitr but never ported to rmarkdown.
I use conditional to use internal knitr function.