downloads: alternate archive layouts #730
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is not the most efficient approach, but attempts multiple repository archive layouts before giving up. reduces the number of download attempts before giving up. generally, a single retry is enough. also reduces the cost of additional layout attempts. fixes #583
aronatkins
force-pushed
the
aron-alternate-archive-layouts
branch
from
9b7cfd7 to
8370948
Compare
kevinushey
approved these changes
Jan 31, 2025
|
@kevinushey - Do you think it's worth adapting a memoizing technique like you use in renv? I can certainly add an opt-out that falls back to the CRAN-only approach. |
I'm sort of on the fence... how close are we to phasing out internal use of packrat? It might be fine to just take this PR as-is and leave it alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is not the most efficient approach, but attempts multiple repository archive layouts before giving up.
reduces the number of download attempts before giving up. generally, a single retry is enough. also reduces the cost of additional layout attempts.
fixes #583