Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed version of #1346: Allow split_by to accept numeric values #1490

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixed version of #1346: Allow split_by to accept numeric values #1490

wants to merge 6 commits into from

Conversation

katrinabrock
Copy link
Contributor

No description provided.

katrinabrock and others added 4 commits February 5, 2025 15:59
@katrinabrock
lcougnaud's split_by squashed
6269184 
Squashed commit of the following:

commit 99f8698
Author: Laure Cougnaud <[email protected]>
Date:   Tue Jun 14 10:33:16 2022 +0000

    limit numeric split_by to: [1:6] + update documentation

commit 3304d5a
Merge: 7f1e38b 4cdf9c6
Author: Laure Cougnaud <[email protected]>
Date:   Tue Jun 14 08:20:17 2022 +0000

    merge branches

    Merge remote-tracking branch 'OAGithubRStudio/main' into split_by-numeric

    # Conflicts:
    #	R/gitbook.R
    #	R/html.R
    #	man/build_chapter.Rd
    #	man/epub_book.Rd
    #	man/gitbook.Rd
    #	man/html_chapters.Rd
    #	man/html_document2.Rd
    #	man/pdf_book.Rd
    #	man/publish_book.Rd
    #	man/render_book.Rd
    #	man/resolve_refs_html.Rd
    #	man/serve_book.Rd

commit 7f1e38b
Author: lcougnaud <[email protected]>
Date:   Mon Nov 4 11:03:18 2019 +0100

    fix for nested subsection (part 1)

commit ee342c7
Author: lcougnaud <[email protected]>
Date:   Thu Oct 31 16:17:33 2019 +0100

    fix specification split_by

commit 60bb103
Author: lcougnaud <[email protected]>
Date:   Thu Oct 31 14:25:09 2019 +0100

    fix inclusion subsections

commit 9c11691
Author: lcougnaud <[email protected]>
Date:   Thu Oct 24 18:05:31 2019 +0200

    split_chapters: fix numbering higher level sections that split_by

commit 0442817
Author: lcougnaud <[email protected]>
Date:   Thu Oct 24 17:42:57 2019 +0200

    update split_chapters for numeric 'split_by'
@lcougnaud @katrinabrock
add tests for split_by as numeric + improve indentation
ed7fea7
@katrinabrock
order git book split_by
ed91de3
@katrinabrock
Fix rmd test failure
acc0166
@katrinabrock katrinabrock changed the title Split by rebased Fixed version of #1346: Allow split_by to accept numeric values Feb 6, 2025
@katrinabrock
Copy link
Contributor Author

Same content as #1346 but with the failing tests fixed :-)

@katrinabrock katrinabrock mentioned this pull request Feb 6, 2025
Open
@katrinabrock
Copy link
Contributor Author

You can cleanly cherry pick every thing after the add tests... commit on to @lcougnaud 's PR if that's better for giving them proper credit than merging this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katrinabrock @lcougnaud