-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next version update (March 2020) #218
base: master
Are you sure you want to change the base?
Conversation
Nicely done so far, keep up the good work. |
I created a PR for css variables |
- Change unpkg to cdn.jsdelivr.net - Remove customization section - Add jQuery integration notes
49acc27
to
2eddc79
Compare
Looking good my friend. Keep up the good work !!! |
3552a11
to
0c88038
Compare
Just chiming in to say: I just tried |
@rstacruz For what it's worth: I did some more testing and on iOS Safari the behavior of the progress bar is different than before. When start() is called and it takes a "long" (like 3s) time before done(), the bar progress is not smooth. It jumps back and forth constantly like it's freezing. I was able to reproduce the behavior in a very simple example (using
Same CodeSandbox but using |
Hey, would you be interested to add the ability to render multiple progress bar in one page? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rstacruz This looks amaze-ballss! Looks like it's done, too. Merge & release it! :D
Hey @rstacruz , adding Sass and TypeScript types is exactly what I was looking for! Seems like you finished all the work already and just the documentation is missing? Also I couldnt find the TypeScript typings so I needed to additionally install Btw. could you please also make the |
Just checking up on this—@rstacruz let us know how we can help 🎉 |
Any update on this package, or has it been abandoned? Would like to know either way what the plan is for this component. |
This updates NProgress to keep it up-to-date with 2020 standards.
Major updates
Distirbute an ESM build. NProgress is currently a UMD distribution (ie, CommonJS and browser).
Add CSS variables support. It should be easier to change the color.
Add Sass support. Same goal as above for those who prefer Sass.
Types and documentation. This should hopefully make the experience better for TypeScript and VSCode users.
Build process updates
jest
for tests (rather than Mocha and Chai).prettier
for code formatting.microbundle
to distribute UMD, ESM, and CommonJS builds.yarn
for packaging.np
for publishing.CI updates
Deprecations
Documentation update
CSS updates