Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final cleanups before version 2 can be released. #30

Merged
merged 9 commits into from
Sep 13, 2020

Conversation

Flameeyes
Copy link
Collaborator

This cleans up a bit after setup.py, and removes the six dependency that is now unneeded.

This removes the dependency from the package, since now we're requiring
Python 3.5 anyway.
Note that the package_data entries were not actually in use: those files
are top-level rather than part of a package, so the resulting distribution
is identical.
@Flameeyes
Copy link
Collaborator Author

@rshk I'll leave to you to merge this one, and do the tag/release dance if you have a moment — I think we're in a good place for releasing version 2.0.0, Python 3 only and with write support.

@Flameeyes
Copy link
Collaborator Author

https://github.com/Flameeyes/usbmon-tools/tree/pcapngwrite is a practical test case for this one.

Revert the name change to underscore, but keep the rest.

Note that this removes CHANGELOG.rst from the PyPI descriptor, which is
probably correct.
@Flameeyes
Copy link
Collaborator Author

Hm the failure with Travis CI is because pytest-pycodestyle now requires Python 3.6+.

I guess we could remove it from 3.5.

This is reported by the newer versions of flake8.
The pytest-pycodestyle package is now a Python 3.6+ dependency, so it will
fail on 3.5. But even so, we don't need it, as flake8 (already ran as part
of pre-commit) already runs codestyle.
@Flameeyes
Copy link
Collaborator Author

@rshk can you please take a look? Or should I just merge this by Tuesday if you don't object? :)

@rshk
Copy link
Owner

rshk commented Sep 13, 2020

Looks good 👍 anything in particular you want me to look at? Happy to to merge otherwise. Is this the last PR before a 2.0 release?

@Flameeyes
Copy link
Collaborator Author

Looks good 👍 anything in particular you want me to look at? Happy to to merge otherwise. Is this the last PR before a 2.0 release?

I think it should be, yes. Adding typing (#32) is probably worth keeping on a follow up release, so that users can keep this version until.they fix up their callsites.

Would you like to do the honours for a release? 😄

@Flameeyes Flameeyes merged commit 48d27b9 into rshk:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants