Atomic modification operations for lifted arrays #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is entirely safe. Could another thread see the successful swap before it sees the "preceding" |
|
I suspect that the CAS gives an ordering guarantee, but I'm not entirely sure. |
treeowl
force-pushed
the
ama
branch
5 times, most recently
from
f62f567 to
bdb1e3e
Compare
|
@winterland1989, what do you think of these? |
|
The code seems OK, may need some tests and benchs, but i'm agree with you that we really should implement this in cmm. |
treeowl
commented
Jun 22, 2018
| -> IO b | ||
| atomicModifyArrayElem' mary i fn = do | ||
| (new, res) <- atomicModifyArrayElem_ mary i fn | ||
| evaluate new |
There was a problem hiding this comment.
We should actually just seq here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #64