Add support for Adafruit Metro RP2040 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedcharles
reviewed
Oct 7, 2023
ahmedcharles
reviewed
Oct 7, 2023
ahmedcharles
reviewed
Oct 7, 2023
ThadHouse
force-pushed
the
adafruit-metro-rp2040
branch
from
937a21e to
fb92792
Compare
ahmedcharles
reviewed
Oct 8, 2023
ThadHouse
force-pushed
the
adafruit-metro-rp2040
branch
from
fb92792 to
5adc2e7
Compare
ahmedcharles
approved these changes
Oct 8, 2023
ThadHouse
force-pushed
the
adafruit-metro-rp2040
branch
2 times, most recently
from
b68a33f to
33002cb
Compare
|
I fixed rainbow. |
Adds support for https://www.adafruit.com/product/5786 Copied mostly from the adafruit-itsy-bitsy-rp2040
ThadHouse
force-pushed
the
adafruit-metro-rp2040
branch
from
33002cb to
e0afd75
Compare
ithinuel
approved these changes
Oct 15, 2023
There was a problem hiding this comment.
Overall looks good to me.
I cross-checked the pin names and things seem to checkout 👍
I start feeling like those examples are pretty redundant as we find them on nearly every rp2040 boards.
It'd be nice to have one showcasing the board's specific feature/differenciator.
E.G. something around the SDCard on this one.
|
Agreed on the examples, but they shouldn't be blockers to getting board libraries merged. IMO having examples should be separate requirements from the actual board libraries being created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for https://www.adafruit.com/product/5786
Copied mostly from the adafruit-itsy-bitsy-rp2040