BUG: get_variable for postgres never returns a value. #9710
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$this->variables[$varname] = rcube::get_instance()->config->get('db_' . $varname);
if (!isset($this->variables)) {
The first line always creates an array "variables"
and because of this the server variables are never read.
Because of this, the insert_or_update() method never uses the
"INSERT INTO ... ON CONFLICT DO UPDATE SET ..."
command, and the logs constantly show errors adding records to the message cache
due to "duplicate key".
vel21ripn
force-pushed
the
psql_get_variable
branch
from
e839c74 to
2981adc
Compare
alecpl
pushed a commit
that referenced
this pull request
Nov 24, 2024
Because of this, the insert_or_update() method never uses the "INSERT INTO ... ON CONFLICT DO UPDATE SET ..." command, and the logs constantly show errors adding records to the message cache due to "duplicate key".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$this->variables[$varname] = rcube::get_instance()->config->get('db_' . $varname);
if (!isset($this->variables)) {
The first line always creates an array "variables" and because of this the server variables are never read.
Because of this, the insert_or_update() method never uses the
"INSERT INTO ... ON CONFLICT DO UPDATE SET ..."
command, and the logs constantly show errors adding records to the message cache due to "duplicate key".