oauth: feat: add support of PKCE #9287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecpl
requested changes
Dec 26, 2023
| ]; | ||
| } | ||
|
|
||
| $this->log_debug("requesting authorization code via a redirect to %s with scope='%s' and pkce method=%s", |
There was a problem hiding this comment.
I'm just thinking maybe logging the full url instead would be better.
There was a problem hiding this comment.
I did it to avoid leak of sensitive data like the nonce in other pull request
EdouardVanbelle
force-pushed
the
feat/oauth-pkce
branch
from
27c5d0b to
c65d257
Compare
This was referenced Dec 27, 2023
Merged
alecpl
requested changes
Dec 27, 2023
Signed-off-by: Edouard Vanbelle <[email protected]>
EdouardVanbelle
force-pushed
the
feat/oauth-pkce
branch
from
c65d257 to
100f1b7
Compare
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello please find the PKCE implementation (RFC 7636)
S256hash methodS256right now)This covers this request: #8757