Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loading message to mail and contacts list #9027

Merged
merged 4 commits into from
Jan 3, 2025
Merged

add loading message to mail and contacts list #9027

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f99fd1b
only show 'this list is empty' message after listing/searching action…
johndoh Dec 4, 2024
e4d952f
wait for list to load in Browser\Contacts\ExportTest::testExportSelec…
johndoh Dec 4, 2024
8be22c8
Changelog entry for clearing "list is empty" message
pabzm Jan 3, 2025
c8e4a02
Merge branch 'master' into list-loading
pabzm Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
only show 'this list is empty' message after listing/searching action… 
… complete
  • Loading branch information
@johndoh
johndoh committed Jan 3, 2025
commit f99fd1bda5eebe9b5f174c2715a7cace723d29f9
13 changes: 6 additions & 7 deletions skins/elastic/ui.js
View file
Original file line number Diff line number Diff line change
@@ -633,9 +633,7 @@ function rcube_elastic_ui() {
msg = table.data('label-msg'),
list = table.is('ul') ? table : table.children('tbody');

if (!rcmail.env.search_request && !rcmail.env.qsearch
&& msg && !list.children(':visible').length
) {
if (msg && !list.children(':visible').length) {
ext = table.data('label-ext');
command = table.data('create-command');

@@ -644,15 +642,16 @@ function rcube_elastic_ui() {
}

info.text(msg).removeClass('hidden');
return;
}

info.addClass('hidden');
},
callback = function () {
info.addClass('hidden');

// wait until the UI stops loading and the list is visible
if (rcmail.busy || !table.is(':visible')) {
return setTimeout(callback, 250);
clearTimeout(env.list_timer);
env.list_timer = setTimeout(callback, 250);
return;
}

clearTimeout(env.list_timer);