feat: add trip details page #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rosvik
commented
Jan 22, 2025
rosvik
commented
Now that we now show transport modes in the trip suggestion lists while details are open (e43561e), it might make sense to remove the option to hide details all together. In my view, this has three advantages: - It's one key press less to get to info like departure times. - Less code complexity. - We can use the main "Enter" action for something other than toggling details. It might be interesting to add a separate trip suggestion detail page, that shows more info on each leg.
rosvik
force-pushed
the
rosvik/trip-details
branch
from
cbaac95 to
7e6c958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.