[jazzy] Bugfix: Recorder discovery does not restart after being stopped (backport #1894) #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Invert start discovery condition Repeated calls to start_discovery should not start additional topics discovery tasks without stop_discovery calls Signed-off-by: Øystein Sture <[email protected]> * Rename stop_discovery to discovery_running and change logic accordingly Signed-off-by: Øystein Sture <[email protected]> --------- Signed-off-by: Øystein Sture <[email protected]> (cherry picked from commit b483541)
mergify
bot
requested review from
james-rms and
jhdcs
and removed request for
a team
MichaelOrlov
changed the title
MichaelOrlov
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for a situation when the discovery in Recorder does not restart after being stopped.
Repeated calls to start_discovery should not start additional topics discovery tasks without stop_discovery calls.
This is an automatic backport of pull request Bugfix: Recorder discovery does not restart after being stopped #1894 done by Mergify.