Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RHEL CI warning for rosbag2_storage_mcap. #1883

Merged
merged 2 commits into from
Dec 19, 2024
+2 −2
Merged

fix RHEL CI warning for rosbag2_storage_mcap. #1883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b66eb2d
fix RHEL CI warning for rosbag2_storage_mcap.
fujitatomoya Dec 14, 2024
9987b6d
Style fix.
clalancette Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rosbag2_storage_mcap/test/rosbag2_storage_mcap/test_message_definition_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ TEST(test_message_definition_cache, get_service_message_definitions)
TEST(test_local_message_definition_source, throw_definition_not_found_for_unknown_msg)
{
MessageDefinitionCache source;
ASSERT_THROW({ source.get_full_text("rosbag2_test_msgdefs/msg/UnknownMessage"); },
ASSERT_THROW(source.get_full_text("rosbag2_test_msgdefs/msg/UnknownMessage"),
rosbag2_storage_mcap::internal::DefinitionNotFoundError);

// Throw DefinitionNotFoundError for not found message definition package name
ASSERT_THROW({ source.get_full_text("not_found_msgdefs_pkg/msg/UnknownMessage"); },
ASSERT_THROW(source.get_full_text("not_found_msgdefs_pkg/msg/UnknownMessage"),
rosbag2_storage_mcap::internal::DefinitionNotFoundError);
}
Loading