Add more logging info to storage and reader/writer open operations #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <[email protected]>
rosbag2_storage/src/rosbag2_storage/impl/storage_factory_impl.hpp
Outdated
Show resolved
Hide resolved
|
Looks good to me other than some minor comments. |
fujitatomoya
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
i do not have any objections for this. lgtm with @christophebedard 's comments.
Signed-off-by: Michael Orlov <[email protected]>
|
Pulls: #1881
|
christophebedard
approved these changes
Dec 12, 2024
christophebedard
deleted the
morlov/add-more-logging-to-reader-writer
branch
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
…1881) Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit 0823be2)
MichaelOrlov
added a commit
that referenced
this pull request
Dec 18, 2024
…1881) (#1882) Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit 0823be2) Co-authored-by: Michael Orlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more logging information in cases when the reader or writer fails to open bag files.
storage.uriis an empty stringstorage.uriif fail to open a bag file.