-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatic spellcheck by codespell for common misspellings. #4997
Conversation
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13183844552/artifacts/2548931443. To view the resulting site:
|
b909ade
to
c701049
Compare
Signed-off-by: Tomoya Fujita <[email protected]>
c701049
to
95721f6
Compare
some important notes related to this PR.
rosindex@3a0a0abcf2df:/tmp/doc_repository$ git ls-files '*.md' '*.rst' | xargs codespell --ignore-words=codespell_whitelist.txt
source/Releases/Beta3-Overview.rst:29: Readded ==> Re-added, Read
source/Releases/Galactic-Geochelone-Complete-Changelog.rst:738: explictly ==> explicitly
source/Releases/Galactic-Geochelone-Complete-Changelog.rst:768: arbitraty ==> arbitrary
source/Releases/Galactic-Geochelone-Complete-Changelog.rst:775: Servin ==> Serving
source/Releases/Galactic-Geochelone-Complete-Changelog.rst:775: Idel ==> Idle
source/Releases/Galactic-Geochelone-Complete-Changelog.rst:804: dependancy ==> dependency
source/Releases/Galactic-Geochelone-Complete-Changelog.rst:833: Idel ==> Idle
source/Releases/Galactic-Geochelone-Complete-Changelog.rst:909: paramter ==> parameter
source/Releases/Galactic-Geochelone-Complete-Changelog.rst:1323: Servin ==> Serving
source/Releases/Galactic-Geochelone-Complete-Changelog.rst:1323: Idel ==> Idle
...
rosindex@3a0a0abcf2df:/tmp/doc_repository$ time make spellcheck
git ls-files '*.md' '*.rst' | xargs codespell --ignore-words=codespell_whitelist.txt --skip="source/Releases/*"
real 0m0.210s
user 0m0.202s
sys 0m0.008s
i had tried some test for failure case, it can tells where and how exactly it should be fixed. |
@kscottz @christophebedard @clalancette i think this is solid and ready to fly 🤔 compared to |
Signed-off-by: Tomoya Fujita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fujitatomoya you are the absolute best and this looks good to go for now.
Looking at the Code Spell docs it appears they support a custom dictionary. It seems like we could add a custom dictionary to catch some common stuff like "ROS2 -> ROS 2", etc.
actually this is really good idea. after this PR is merged, i will open the issue to brainstorm the ROS 2 doc dictionary👍 |
* automatic spellcheck by codespell for common misspellings. Signed-off-by: Tomoya Fujita <[email protected]> * remove indention from the whitelist. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit b9fb2b4)
* automatic spellcheck by codespell for common misspellings. Signed-off-by: Tomoya Fujita <[email protected]> * remove indention from the whitelist. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit b9fb2b4)
…4999) * automatic spellcheck by codespell for common misspellings. Signed-off-by: Tomoya Fujita <[email protected]> * remove indention from the whitelist. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit b9fb2b4) Co-authored-by: Tomoya Fujita <[email protected]>
…5000) * automatic spellcheck by codespell for common misspellings. Signed-off-by: Tomoya Fujita <[email protected]> * remove indention from the whitelist. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit b9fb2b4) Co-authored-by: Tomoya Fujita <[email protected]>
@clalancette @kscottz @christophebedard thanks for the review, permissive spell check is now online for all distros! as Kat suggested above, ROS 2 dictionary approach can be good without having false alarms. i will look into that feature, and create the issue for that. |
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/requesting-help-lets-make-ros-2-dictionary-for-spell-checker/42005/1 |
follow-up of #4980.