-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ServiceData thread-safe #292
Conversation
Signed-off-by: Yadunund <[email protected]>
rmw_zenoh/yadu/raii-service
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments. Tests are in the same status, I think it's safe to merge it
This PR ros2/rclcpp#2648 removed the wait_set failure |
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
4a0d2da
to
7d55c76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested this with the Nav2 test, and it seems to work pretty well.
Thread-safe access to the
rmw_service_t
handler. Followed the exact same pattern as in #288