Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore exceptions raised in user created tasks #1395

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Ignore exceptions raised in user created tasks #1395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions rclpy/rclpy/executors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,10 +851,9 @@ def _spin_once_impl(
pass
else:
handler()
if handler.exception() is not None:
raise handler.exception()

handler.result() # raise any exceptions
if entity is not None:
# if the task was not created by the user
handler.result() # raise any exceptions

def spin_once(self, timeout_sec: Optional[float] = None) -> None:
self._spin_once_impl(timeout_sec)
Expand Down