Add Publisher::get_subscription_count #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhdcs
requested changes
Feb 3, 2025
romainreignier
force-pushed
the
feature/add_get_subscription_count
branch
from
ba8e6ac to
e76157f
Compare
|
Looking good so far! I did think of one other thing that should probably be added. In the bottom of the file, there is a Sorry for the extra task there, wish I had thought of it before... |
romainreignier
force-pushed
the
feature/add_get_subscription_count
branch
from
e76157f to
11128b9
Compare
|
Thanks for the suggestion, I have added the tests. |
romainreignier
force-pushed
the
feature/add_get_subscription_count
branch
from
11128b9 to
3e04892
Compare
|
Sorry, I had missed a publisher to test. I have tried to add a to each topic and it works as well. |
romainreignier
force-pushed
the
feature/add_get_subscription_count
branch
from
3e04892 to
5e162f2
Compare
jhdcs
approved these changes
Feb 4, 2025
|
Confirmed that this works on my setup. Thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #456
This is my first contribution to ros2_rust and I am not sure about the return code handling and safety comment.
Any feedback is welcomed.