Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build instructions missing build context #448

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

rcywongaa
Copy link
Contributor

@rcywongaa rcywongaa commented Dec 17, 2024

CI failing due to #449

@rcywongaa rcywongaa force-pushed the fix_docker_instructions branch 3 times, most recently from 4a13acf to 62515cd Compare December 17, 2024 05:41
@rcywongaa rcywongaa force-pushed the fix_docker_instructions branch from 62515cd to 24697f3 Compare December 17, 2024 05:42
Copy link
Collaborator

@maspe36 maspe36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@maspe36
Copy link
Collaborator

maspe36 commented Feb 1, 2025

Going to merge this as the docs folder is not moving with the repository restructuring and even though CI is failing, that was unrelated to this change as mentioned above.

@maspe36 maspe36 merged commit 83ab23a into ros2-rust:main Feb 1, 2025
3 of 6 checks passed
@rcywongaa rcywongaa deleted the fix_docker_instructions branch February 1, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants