Adding a simple helper function for converting rclrs::Time to a ros message
#359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
message This commit adds a simple conversion function that would converts Time to builtin_interfaces like the one in rclpy. Signed-off-by: Arjo Chakravarty <[email protected]>
jhdcs
requested changes
Jan 10, 2024
There was a problem hiding this comment.
I like this! Nice and simple, easy to understand, and helps the end user to do their job more efficiently. Thank you!
Only catch is that there appears to be some formatting issues that the linter isn't happy about. Would you be able to modify your submission so that the linter lets the rest of the tests run? Apart from that, this looks pretty good to me!
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
|
Looks like my last commit dismissed the review 🤷 . I'd be happy to make similar PRs for Duration and the time going the other way. |
jhdcs
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a simple conversion function that converts Time to
builtin_interfaces::msg::Timelike the one inrclpy.