-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ament_black: 0.2.3-1 in 'rolling/distribution.yaml' [bloom] #38762
Conversation
The best practices for Rolling releases is to use a release repository in the https://github.com/ros2-gbp organization. That way this package can be automatically released from Rolling into the next stable ROS distribution. There are instructions in https://github.com/ros2-gbp/ros2-gbp-github-org/blob/latest/CONTRIBUTING.md describing how to create one. Do you already have a PR open to add this to |
@quarkytale Thanks for the info. I created an issue as I found somewhere in the documentation on the repo few days ago : ros2-gbp/ros2-gbp-github-org#342 What would be the next step? Should I wait to have this release team already on the main branch? Should I create the PR on Thanks in advance. |
You can either create the PR on that repository, or wait for the maintainer to do it. |
Thanks @clalancette |
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
@nuclearsandwich how can I help to move this forward 🤔 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated release repository to the ros2-gbp mirror.
Thanks for your patience @nachovizzo, the outstanding work was entirely on me and I've just been behind on reviews. This has been resolved and I've mirrored the original release repository to ros2-gbp and updated this PR. Once CI passes this can merge and you should have an invitation to join the ros2-gbp org which will give you access for further releases. |
Thanks for your patience @nachovizzo I have been working through a huge review backlog and so the delay was entirely on me. I've updated the ros2-gbp repository with changes from the original. I recommend archiving https://github.com/botsandus/ament_black-release to prevent it from being used unintentionally. |
Wow! Great work. Thanks! I was planning on mirroring the release repo tonight, but thanks for moving faster than me! Before archiving the repo I will open a PR here to change the upstream for EDIT: PR here #38863 |
DONE: https://github.com/botsandus/ament_black-release archived, and |
Increasing version of package(s) in repository
ament_black
to0.2.3-1
:rolling/distribution.yaml
0.11.2
null
ament_black
ament_cmake_black