Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_black: 0.2.3-1 in 'rolling/distribution.yaml' [bloom] #38762

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

nachovizzo
Copy link
Contributor

Increasing version of package(s) in repository ament_black to 0.2.3-1:

ament_black

* Add python3-uvloop as dependency https://github.com/ros/rosdistro/pull/38754
* Contributors: Ignacio Vizzo

ament_cmake_black

* Fix amenx_xmllint test
* Contributors: Ignacio Vizzo

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Oct 13, 2023
@quarkytale
Copy link
Contributor

The best practices for Rolling releases is to use a release repository in the https://github.com/ros2-gbp organization. That way this package can be automatically released from Rolling into the next stable ROS distribution. There are instructions in https://github.com/ros2-gbp/ros2-gbp-github-org/blob/latest/CONTRIBUTING.md describing how to create one. Do you already have a PR open to add this to ros2-gbp?

@quarkytale quarkytale added held for sync Issue/PR has been held because the distribution is in a sync hold changes requested Maintainers have asked for changes to the pull request ros2-gbp Pending release into ros2-gbp labels Oct 13, 2023
@nachovizzo
Copy link
Contributor Author

@quarkytale Thanks for the info.

I created an issue as I found somewhere in the documentation on the repo few days ago : ros2-gbp/ros2-gbp-github-org#342

What would be the next step? Should I wait to have this release team already on the main branch? Should I create the PR on ros2-gbp to add the release team?

Thanks in advance.

@clalancette
Copy link
Contributor

What would be the next step? Should I wait to have this release team already on the main branch? Should I create the PR on ros2-gbp to add the release team?

You can either create the PR on that repository, or wait for the maintainer to do it.

@nachovizzo
Copy link
Contributor Author

Thanks @clalancette
I already did to help a bit ;)
ros2-gbp/ros2-gbp-github-org#346

Copy link

github-actions bot commented Nov 1, 2023

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Nov 1, 2023
@nachovizzo
Copy link
Contributor Author

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@nuclearsandwich how can I help to move this forward 🤔 ?

@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Nov 2, 2023
@quarkytale quarkytale added the persistent Issue/PR won't be marked as stale if inactive for a while. label Nov 2, 2023
@nuclearsandwich nuclearsandwich removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Nov 3, 2023
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated release repository to the ros2-gbp mirror.

rolling/distribution.yaml Outdated Show resolved Hide resolved
@nuclearsandwich
Copy link
Member

@nuclearsandwich how can I help to move this forward 🤔 ?

Thanks for your patience @nachovizzo, the outstanding work was entirely on me and I've just been behind on reviews. This has been resolved and I've mirrored the original release repository to ros2-gbp and updated this PR. Once CI passes this can merge and you should have an invitation to join the ros2-gbp org which will give you access for further releases.

@nuclearsandwich nuclearsandwich merged commit d2a4e60 into ros:master Nov 6, 2023
@nuclearsandwich
Copy link
Member

@nuclearsandwich how can I help to move this forward 🤔 ?

Thanks for your patience @nachovizzo I have been working through a huge review backlog and so the delay was entirely on me. I've updated the ros2-gbp repository with changes from the original. I recommend archiving https://github.com/botsandus/ament_black-release to prevent it from being used unintentionally.

@nachovizzo
Copy link
Contributor Author

nachovizzo commented Nov 6, 2023

@nuclearsandwich how can I help to move this forward 🤔 ?

Thanks for your patience @nachovizzo I have been working through a huge review backlog and so the delay was entirely on me. I've updated the ros2-gbp repository with changes from the original. I recommend archiving https://github.com/botsandus/ament_black-release to prevent it from being used unintentionally.

Wow! Great work. Thanks!

I was planning on mirroring the release repo tonight, but thanks for moving faster than me!

Before archiving the repo I will open a PR here to change the upstream for humble and iron.

EDIT: PR here #38863

@nachovizzo nachovizzo deleted the bloom-ament_black-5 branch November 6, 2023 16:00
@nachovizzo
Copy link
Contributor Author

@nuclearsandwich how can I help to move this forward 🤔 ?

Thanks for your patience @nachovizzo I have been working through a huge review backlog and so the delay was entirely on me. I've updated the ros2-gbp repository with changes from the original. I recommend archiving https://github.com/botsandus/ament_black-release to prevent it from being used unintentionally.

DONE: https://github.com/botsandus/ament_black-release archived, and rosdistro updated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request persistent Issue/PR won't be marked as stale if inactive for a while. rolling Issue/PR is for the ROS 2 Rolling distribution ros2-gbp Pending release into ros2-gbp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants