Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_black: 0.2.0-1 in 'iron/distribution.yaml' #38736

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

nachovizzo
Copy link
Contributor

Increasing version of package(s) in repository ament_black to 0.2.0-1:

ament_black

* Create a new release for a renewed and mantained package
* Contributors: Ignacio Vizzo [Dexory]

ament_cmake_black

* Create a new release for a renewed and mantained package
* Contributors: Ignacio Vizzo [Dexory]

@github-actions github-actions bot added the iron Issue/PR is for the ROS 2 Iron distribution label Oct 9, 2023
@nachovizzo nachovizzo closed this Oct 9, 2023
@nachovizzo nachovizzo reopened this Oct 9, 2023
@nachovizzo
Copy link
Contributor Author

@clalancette I think you might be interested in merging this one ;) Was developed with love at Dexory 🙌

@methylDragon methylDragon merged commit e41b03f into ros:master Oct 9, 2023
@tfoote
Copy link
Member

tfoote commented Oct 12, 2023

@nachovizzo Did you talk to @Timple about taking over maintenance of this package? I don't see any documented communications about this.

@nachovizzo
Copy link
Contributor Author

@tfoote We tried to, but after one month of public silence, I guess it's clear he is not maintaining the repository anymore: Timple/ament_black#8 . It also looks like there is no interest in moving forward. See also: Timple/ament_black#1

But no, I haven't talked with @Timple :) my bad

@Timple
Copy link
Contributor

Timple commented Oct 12, 2023

Wow, whups.

I totally missed the iron release request. I should probably clean up the number of repositories I'm subscribed to, so the ones under own maintenance get better attention.

I'm happy to still release it. But probably it would make more sense to include the improvements you made first?

@nachovizzo
Copy link
Contributor Author

As you wish @Timple . I kept you as the main author ;) I also self-added myself as a maintainer. The release has been done. I just need to bump the version #38753 and inject a new python dependency #38754

You can try it on the ros2-testing repos

@Timple
Copy link
Contributor

Timple commented Oct 12, 2023

I think we need to align iron with humble and rolling in any case.

So either open a PR against my repo so all can benefit.

Or take over maintenance of Humble as well. Since you're actively developing, I am not against transfering maintainership.

@nachovizzo
Copy link
Contributor Author

I'd prefer that we take over the maintenance since our fork is hosted and maintained by Dexory, which will also ensure support for the upcoming ROS releases.

if you are ok with this, I will also release for humble+rolling

@Timple
Copy link
Contributor

Timple commented Oct 12, 2023

Sure thing!

We'll keep happily using this package.

@nachovizzo
Copy link
Contributor Author

@Timple Great! Will do then ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iron Issue/PR is for the ROS 2 Iron distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants