Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the prefix name check for the chainable controllers #2038

Conversation

saikishor
Copy link
Member

This is to improve the prefix_name checking for the exported interfaces from the chainable controllers. This way, we could isolate the interface naming to standard types and use the prefix_name along with the controller_name

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.44%. Comparing base (5d4933d) to head (a5f0511).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...r_interface/src/chainable_controller_interface.cpp 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
+ Coverage   89.43%   89.44%   +0.01%     
==========================================
  Files         138      138              
  Lines       14794    14796       +2     
  Branches     1271     1271              
==========================================
+ Hits        13231    13235       +4     
+ Misses       1087     1086       -1     
+ Partials      476      475       -1     
Flag Coverage Δ
unittests 89.44% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r_interface/src/chainable_controller_interface.cpp 52.17% <80.00%> (+0.84%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Juliaj Juliaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these!

Copy link

@Juliaj Juliaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@destogl destogl merged commit 465e5d0 into ros-controls:master Feb 12, 2025
22 of 25 checks passed
@destogl destogl deleted the improve/chainable/prefix_name/checking branch February 12, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants