-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the prefix name check for the chainable controllers #2038
Improve the prefix name check for the chainable controllers #2038
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
+ Coverage 89.43% 89.44% +0.01%
==========================================
Files 138 138
Lines 14794 14796 +2
Branches 1271 1271
==========================================
+ Hits 13231 13235 +4
+ Misses 1087 1086 -1
+ Partials 476 475 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is to improve the prefix_name checking for the exported interfaces from the chainable controllers. This way, we could isolate the interface naming to standard types and use the prefix_name along with the controller_name