-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak in the ros2_control #2033
Fix memory leak in the ros2_control #2033
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2033 +/- ##
==========================================
+ Coverage 89.33% 89.37% +0.04%
==========================================
Files 138 138
Lines 14772 14762 -10
Branches 1270 1270
==========================================
- Hits 13196 13193 -3
+ Misses 1100 1092 -8
- Partials 476 477 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For some reason, the
get_name
method that is returning by copy is creating various mallocs in the RT loop and this is causing slight memory leaks.gdb with breakpoint on
malloc
, brings me to these logs, so it would be nice to have this sorted to not have allocations in the RT loop